From: "陳韋任 (Wei-Ren Chen)" <chenwj@iis.sinica.edu.tw>
To: Yeongkyoon Lee <yeongkyoon.lee@samsung.com>
Cc: blauwirbel@gmail.com, aurelien@aurel32.net,
qemu-devel@nongnu.org,
"\"陳韋任 (Wei-Ren Chen)\"" <chenwj@iis.sinica.edu.tw>,
rth@twiddle.net
Subject: Re: [Qemu-devel] [RESEND PATCH v6 2/3] tcg: Add extended GETPC mechanism for MMU helpers with ldst optimization
Date: Wed, 24 Oct 2012 11:14:29 +0800 [thread overview]
Message-ID: <20121024031429.GA81458@cs.nctu.edu.tw> (raw)
In-Reply-To: <50875C5B.8080008@samsung.com>
On Wed, Oct 24, 2012 at 12:11:23PM +0900, Yeongkyoon Lee wrote:
> On 2012년 10월 24일 00:25, 陳韋任 (Wei-Ren Chen) wrote:
> > Hi Yeongkyoon,
> >
> >> +#if defined(CONFIG_QEMU_LDST_OPTIMIZATION) && defined(CONFIG_SOFTMMU)
> >> +/* check whether the give addr is in TCG generated code buffer or not */
> > ^^^^
> >
> > should be given.
> >
> > Cheers,
> > chenwj
> >
>
> Thanks a lot, Wei-Ren.
> Probably I should send the next version of the patch.
Or someone who commits this patchset for you can fix typo so that
you don't have to resend it. ;)
Cheers,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj
next prev parent reply other threads:[~2012-10-24 3:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-20 7:05 [Qemu-devel] [RESEND PATCH v6 0/3] tcg: enhance code generation quality for qemu_ld/st IRs Yeongkyoon Lee
2012-10-20 7:05 ` [Qemu-devel] [RESEND PATCH v6 1/3] configure: Add CONFIG_QEMU_LDST_OPTIMIZATION for TCG qemu_ld/st optimization Yeongkyoon Lee
2012-10-20 7:05 ` [Qemu-devel] [RESEND PATCH v6 2/3] tcg: Add extended GETPC mechanism for MMU helpers with ldst optimization Yeongkyoon Lee
2012-10-23 15:25 ` 陳韋任 (Wei-Ren Chen)
2012-10-24 3:11 ` Yeongkyoon Lee
2012-10-24 3:14 ` 陳韋任 (Wei-Ren Chen) [this message]
2012-10-27 14:29 ` Blue Swirl
2012-10-29 5:26 ` Yeongkyoon Lee
2012-10-20 7:05 ` [Qemu-devel] [RESEND PATCH v6 3/3] tcg: Optimize qemu_ld/st by generating slow paths at the end of a block Yeongkyoon Lee
2012-10-25 7:15 ` [Qemu-devel] [RESEND PATCH v6 0/3] tcg: enhance code generation quality for qemu_ld/st IRs Yeongkyoon Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121024031429.GA81458@cs.nctu.edu.tw \
--to=chenwj@iis.sinica.edu.tw \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=yeongkyoon.lee@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).