From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQsUw-0002JH-73 for qemu-devel@nongnu.org; Wed, 24 Oct 2012 00:23:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TQsUv-0000cz-5D for qemu-devel@nongnu.org; Wed, 24 Oct 2012 00:23:18 -0400 Received: from e23smtp05.au.ibm.com ([202.81.31.147]:49080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TQsUu-0000cl-Ks for qemu-devel@nongnu.org; Wed, 24 Oct 2012 00:23:17 -0400 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 24 Oct 2012 14:21:25 +1000 Date: Wed, 24 Oct 2012 14:54:44 +1100 From: David Gibson Message-ID: <20121024035444.GA4311@truffula.fritz.box> References: <1350986975-21786-1-git-send-email-aviksil@linux.vnet.ibm.com> <1350986975-21786-3-git-send-email-aviksil@linux.vnet.ibm.com> <20121023224518.GF13231@truffula.fritz.box> <50874BEF.8050604@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50874BEF.8050604@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 2/2] pseries: set boot-device property only if boot order specified List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avik Sil Cc: aliguori@us.ibm.com, qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Wed, Oct 24, 2012 at 07:31:19AM +0530, Avik Sil wrote: > On 10/24/2012 04:15 AM, David Gibson wrote: > > On Tue, Oct 23, 2012 at 03:39:35PM +0530, Avik Sil wrote: > >> Signed-off-by: Avik Sil > > > > As Anthony suggests, it would be better to explicitly remove the > > normal default boot order in this patch, after adding it for > > absolutely everything in the first patch. > > > > This also needs a better patch comment, explaining the significance of > > the presence/absence of the property on firmware behaviour. > > > Sure. Shall I make the boot order for pseries as NULL string or empty > string? Current patch handles NULL string. NULL is better, I think. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson