* [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE
@ 2012-10-24 16:12 Luiz Capitulino
2012-10-25 20:24 ` Stefan Weil
2012-10-26 15:34 ` Anthony Liguori
0 siblings, 2 replies; 3+ messages in thread
From: Luiz Capitulino @ 2012-10-24 16:12 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, aliguori
Commit ad0b5321f1f797274603ebbe20108b0750baee94 forgot to add
QEMU_MADV_HUGEPAGE macros for when CONFIG_MADVISE is not defined.
This broke the build for Windows. Fix it.
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
osdep.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/osdep.h b/osdep.h
index c5fd3d9..585e2c1 100644
--- a/osdep.h
+++ b/osdep.h
@@ -121,6 +121,7 @@ void qemu_vfree(void *ptr);
#define QEMU_MADV_DONTFORK QEMU_MADV_INVALID
#define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
#define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
+#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
#else /* no-op */
@@ -129,6 +130,7 @@ void qemu_vfree(void *ptr);
#define QEMU_MADV_DONTFORK QEMU_MADV_INVALID
#define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
#define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
+#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
#endif
--
1.7.12.315.g682ce8b
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE
2012-10-24 16:12 [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE Luiz Capitulino
@ 2012-10-25 20:24 ` Stefan Weil
2012-10-26 15:34 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Weil @ 2012-10-25 20:24 UTC (permalink / raw)
To: Luiz Capitulino, aliguori; +Cc: Kevin Wolf, qemu-devel
Am 24.10.2012 18:12, schrieb Luiz Capitulino:
> Commit ad0b5321f1f797274603ebbe20108b0750baee94 forgot to add
> QEMU_MADV_HUGEPAGE macros for when CONFIG_MADVISE is not defined.
> This broke the build for Windows. Fix it.
>
> Signed-off-by: Luiz Capitulino<lcapitulino@redhat.com>
> ---
> osdep.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/osdep.h b/osdep.h
> index c5fd3d9..585e2c1 100644
> --- a/osdep.h
> +++ b/osdep.h
> @@ -121,6 +121,7 @@ void qemu_vfree(void *ptr);
> #define QEMU_MADV_DONTFORK QEMU_MADV_INVALID
> #define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
> #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
> +#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
>
> #else /* no-op */
>
> @@ -129,6 +130,7 @@ void qemu_vfree(void *ptr);
> #define QEMU_MADV_DONTFORK QEMU_MADV_INVALID
> #define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
> #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
> +#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
>
> #endif
>
Reviewed-by: Stefan Weil <sw@weilnetz.de>
This is a build fix for latest QEMU. Please apply it as soon as possible.
Regards
Stefan Weil
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE
2012-10-24 16:12 [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE Luiz Capitulino
2012-10-25 20:24 ` Stefan Weil
@ 2012-10-26 15:34 ` Anthony Liguori
1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2012-10-26 15:34 UTC (permalink / raw)
To: Luiz Capitulino, qemu-devel; +Cc: Kevin Wolf
Luiz Capitulino <lcapitulino@redhat.com> writes:
> Commit ad0b5321f1f797274603ebbe20108b0750baee94 forgot to add
> QEMU_MADV_HUGEPAGE macros for when CONFIG_MADVISE is not defined.
> This broke the build for Windows. Fix it.
>
> Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> osdep.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/osdep.h b/osdep.h
> index c5fd3d9..585e2c1 100644
> --- a/osdep.h
> +++ b/osdep.h
> @@ -121,6 +121,7 @@ void qemu_vfree(void *ptr);
> #define QEMU_MADV_DONTFORK QEMU_MADV_INVALID
> #define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
> #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
> +#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
>
> #else /* no-op */
>
> @@ -129,6 +130,7 @@ void qemu_vfree(void *ptr);
> #define QEMU_MADV_DONTFORK QEMU_MADV_INVALID
> #define QEMU_MADV_MERGEABLE QEMU_MADV_INVALID
> #define QEMU_MADV_DONTDUMP QEMU_MADV_INVALID
> +#define QEMU_MADV_HUGEPAGE QEMU_MADV_INVALID
>
> #endif
>
> --
> 1.7.12.315.g682ce8b
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-26 15:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-24 16:12 [Qemu-devel] [PATCH] win32: fix broken build due to missing QEMU_MADV_HUGEPAGE Luiz Capitulino
2012-10-25 20:24 ` Stefan Weil
2012-10-26 15:34 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).