From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V4 06/10] create new function: qemu_opt_set_number
Date: Fri, 26 Oct 2012 11:02:57 +0200 [thread overview]
Message-ID: <20121026090257.GD19272@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1351169848-28223-7-git-send-email-wdongxu@linux.vnet.ibm.com>
On Thu, Oct 25, 2012 at 08:57:24PM +0800, Dong Xu Wang wrote:
> diff --git a/qemu-option.c b/qemu-option.c
> index d7d5ea9..eeb2c9c 100644
> --- a/qemu-option.c
> +++ b/qemu-option.c
> @@ -695,6 +695,30 @@ int qemu_opt_set_bool(QemuOpts *opts, const char *name, bool val)
> return 0;
> }
>
> +int qemu_opt_set_number(QemuOpts *opts, const char *name, int64_t val)
> +{
> + char buffer[1024];
> + QemuOpt *opt;
> + const QemuOptDesc *desc = opts->list->desc;
> +
> + snprintf(buffer, sizeof(buffer), "%" PRId64, val);
g_strdup_printf() is a nice replacement for fixed-size buffer +
snprintf() + g_strdup():
http://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html#g-strdup-printf
Stefan
next prev parent reply other threads:[~2012-10-26 9:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 12:57 [Qemu-devel] [PATCH V4 00/10] replace QEMUOptionParameter with QemuOpts parser Dong Xu Wang
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 01/10] qemu-option: opt_set(): split it up into more functions Dong Xu Wang
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 02/10] qemu-option: qemu_opts_validate(): fix duplicated code Dong Xu Wang
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication Dong Xu Wang
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 04/10] introduce qemu_opts_create_nofail function Dong Xu Wang
2012-10-25 13:06 ` Peter Maydell
2012-10-26 2:46 ` Dong Xu Wang
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 05/10] use qemu_opts_create_nofail Dong Xu Wang
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 06/10] create new function: qemu_opt_set_number Dong Xu Wang
2012-10-26 9:02 ` Stefan Hajnoczi [this message]
2012-10-29 8:03 ` Dong Xu Wang
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 07/10] add def_value and use it in qemu_opts_print Dong Xu Wang
2012-10-26 9:32 ` Stefan Hajnoczi
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 08/10] Create four opts list related functions Dong Xu Wang
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 09/10] Use QemuOpts support in block layer Dong Xu Wang
2012-10-26 9:51 ` Stefan Hajnoczi
2012-10-25 12:57 ` [Qemu-devel] [PATCH V4 10/10] remove QEMUOptionParameter related functions and struct Dong Xu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121026090257.GD19272@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=wdongxu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).