From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:41914)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TRfom-00018Q-2M
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 05:03:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TRfok-0006qP-A0
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 05:03:04 -0400
Received: from mail-bk0-f45.google.com ([209.85.214.45]:46766)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TRfok-0006pz-3F
	for qemu-devel@nongnu.org; Fri, 26 Oct 2012 05:03:02 -0400
Received: by mail-bk0-f45.google.com with SMTP id jf3so969985bkc.4
	for <qemu-devel@nongnu.org>; Fri, 26 Oct 2012 02:03:01 -0700 (PDT)
Date: Fri, 26 Oct 2012 11:02:57 +0200
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20121026090257.GD19272@stefanha-thinkpad.redhat.com>
References: <1351169848-28223-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<1351169848-28223-7-git-send-email-wdongxu@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1351169848-28223-7-git-send-email-wdongxu@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V4 06/10] create new function:
 qemu_opt_set_number
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On Thu, Oct 25, 2012 at 08:57:24PM +0800, Dong Xu Wang wrote:
> diff --git a/qemu-option.c b/qemu-option.c
> index d7d5ea9..eeb2c9c 100644
> --- a/qemu-option.c
> +++ b/qemu-option.c
> @@ -695,6 +695,30 @@ int qemu_opt_set_bool(QemuOpts *opts, const char *name, bool val)
>      return 0;
>  }
>  
> +int qemu_opt_set_number(QemuOpts *opts, const char *name, int64_t val)
> +{
> +    char buffer[1024];
> +    QemuOpt *opt;
> +    const QemuOptDesc *desc = opts->list->desc;
> +
> +    snprintf(buffer, sizeof(buffer), "%" PRId64, val);

g_strdup_printf() is a nice replacement for fixed-size buffer +
snprintf() + g_strdup():

http://developer.gnome.org/glib/2.28/glib-String-Utility-Functions.html#g-strdup-printf

Stefan