[Qemu-devel] [PATCH v7 1/1] target-i386: Add missing kvm bits.

[Qemu-devel] [PATCH v7 1/1] target-i386: Add missing kvm bits.

[Don Slutz]

Currently "-cpu host,-kvmclock,-kvm_nopiodelay,-kvm_mmu" does not
turn off all bits in CPUID 0x40000001 EAX.

The missing ones are KVM_FEATURE_STEAL_TIME and
KVM_FEATURE_CLOCKSOURCE_STABLE_BIT.

This adds the names kvm_steal_time and kvm_clock_stable for these
bits.

Signed-off-by: Don Slutz <Don@CloudSwitch.com>
---
 target-i386/cpu.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index f3708e6..e9c760d 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -87,10 +87,14 @@ static const char *ext3_feature_name[] = {
 };
 
 static const char *kvm_feature_name[] = {
-    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock", "kvm_asyncpf", NULL, "kvm_pv_eoi", NULL,
-    NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
-    NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
+    "kvmclock", "kvm_nopiodelay", "kvm_mmu", "kvmclock",
+    "kvm_asyncpf", "kvm_steal_time", "kvm_pv_eoi", NULL,
+    NULL, NULL, NULL, NULL,
+    NULL, NULL, NULL, NULL,
+    NULL, NULL, NULL, NULL,
+    NULL, NULL, NULL, NULL,
+    "kvm_clock_stable", NULL, NULL, NULL,
+    NULL, NULL, NULL, NULL,
 };
 
 static const char *svm_feature_name[] = {
-- 
1.7.1

[Qemu-devel] [PATCH v7 0/1] target-i386: Add missing kvm bits.

[Don Slutz]

This was part of [PATCH v6 00/16] Allow changing of Hypervisor CPUIDs.

Since it is no longer in use by any of the patches in v7, I have split it off.

Don Slutz (1):
  target-i386: Add missing kvm bits.

 target-i386/cpu.c |   12 ++++++++----
 1 files changed, 8 insertions(+), 4 deletions(-)

Re: [Qemu-devel] [PATCH v7 1/1] target-i386: Add missing kvm bits.

[Marcelo Tosatti]

On Fri, Oct 12, 2012 at 03:43:23PM -0400, Don Slutz wrote:
> Currently "-cpu host,-kvmclock,-kvm_nopiodelay,-kvm_mmu" does not
> turn off all bits in CPUID 0x40000001 EAX.
> 
> The missing ones are KVM_FEATURE_STEAL_TIME and
> KVM_FEATURE_CLOCKSOURCE_STABLE_BIT.
> 
> This adds the names kvm_steal_time and kvm_clock_stable for these
> bits.
> 
> Signed-off-by: Don Slutz <Don@CloudSwitch.com>

It does not make sense to expose KVM_FEATURE_STEAL_TIME 
to the user (as its going to be controlled by the kernel), applied
with kvm_steal_time addition only. Thanks.