From: David Gibson <dwg@au1.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH v2 1/2] Make default boot order machine specific
Date: Mon, 29 Oct 2012 13:41:38 +1100 [thread overview]
Message-ID: <20121029024138.GE27695@truffula.fritz.box> (raw)
In-Reply-To: <CAFEAcA9orkoAjjYd7U=Jzdr8LkzfePOiUAeUQNM_3rt_O9rLNg@mail.gmail.com>
On Thu, Oct 25, 2012 at 09:50:10PM +0100, Peter Maydell wrote:
> On 25 October 2012 21:18, Anthony Liguori <aliguori@us.ibm.com> wrote:
> > The other approach to this would be:
> >
> > static QEMUMachine pseries_machine = {
> > .no_boot_order = 1,
> > };
> >
> > Which I think is what Peter is suggesting. I'm not a huge fan of this
> > because it's backwards logic but we already do this for a bunch of other
> > things so I can't object too strongly to it.
>
> The other issue is that "cad" is a load of rubbish for half of these
> boards, which don't have anything resembling the usual PC boot
> devices and probably don't pay attention to -boot anyway. A patch
> which only applied a boot order to boards which actually used it
> would probably also be rather shorter.
True, but I don't think it's reasonable to expect people other than
the maintainers of those boards to make that judgement. The correct
approach is to keep the same behaviour for now, then let individual
boards change away from it.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-10-29 2:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-25 14:38 [Qemu-devel] [PATCH v2 0/2] Qemu boot order patch series Avik Sil
2012-10-25 14:38 ` [Qemu-devel] [PATCH v2 1/2] Make default boot order machine specific Avik Sil
2012-10-25 17:01 ` Peter Maydell
2012-10-25 20:18 ` Anthony Liguori
2012-10-25 20:50 ` Peter Maydell
2012-10-25 20:57 ` Alexander Graf
2012-10-26 11:45 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2012-11-05 11:34 ` Avik Sil
2012-11-23 16:52 ` Alexander Graf
2012-11-27 17:24 ` Avik Sil
2012-12-05 17:05 ` Avik Sil
2012-10-29 2:41 ` David Gibson [this message]
2012-10-29 0:15 ` David Gibson
2012-10-25 14:38 ` [Qemu-devel] [PATCH v2 2/2] pseries: set no default boot order Avik Sil
2012-10-25 16:49 ` [Qemu-devel] [PATCH v2 0/2] Qemu boot order patch series Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121029024138.GE27695@truffula.fritz.box \
--to=dwg@au1.ibm.com \
--cc=aliguori@us.ibm.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).