From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59640) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSkwU-0001Dj-UW for qemu-devel@nongnu.org; Mon, 29 Oct 2012 04:43:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSkwQ-0002BW-UR for qemu-devel@nongnu.org; Mon, 29 Oct 2012 04:43:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:31329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSkwQ-0002BK-Mb for qemu-devel@nongnu.org; Mon, 29 Oct 2012 04:43:26 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9T8hP9d017274 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 29 Oct 2012 04:43:25 -0400 Date: Mon, 29 Oct 2012 09:43:22 +0100 From: Stefan Hajnoczi Message-ID: <20121029084322.GA8917@stefanha-thinkpad.redhat.com> References: <1351256493-18923-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1351256493-18923-1-git-send-email-kraxel@redhat.com> Subject: Re: [Qemu-devel] [PATCH] uhci: stick irq routing info into UHCIInfo too. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Fri, Oct 26, 2012 at 03:01:33PM +0200, Gerd Hoffmann wrote: > Kills the ugly "switch (device_id) { ... }" struct and makes it easier > to figure what the differences between the uhci variants are. > > Need our own DeviceClass struct for that so we can allocate some space > to store UHCIInfo. > > Signed-off-by: Gerd Hoffmann > --- > hw/usb/hcd-uhci.c | 32 ++++++++++++++++++-------------- > 1 files changed, 18 insertions(+), 14 deletions(-) Reviewed-by: Stefan Hajnoczi