* [Qemu-devel] [PATCH] configure: Remove stray debug output
@ 2012-10-20 19:37 Peter Maydell
2012-10-29 9:54 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-11-16 14:28 ` Stefan Hajnoczi
0 siblings, 2 replies; 4+ messages in thread
From: Peter Maydell @ 2012-10-20 19:37 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, patches
Rather than printing a message saying we're silently falling
back to gthread coroutines when running on MacOS, actually
do it silently.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
I guess this is a self-falsifying echo :-)
configure | 2 --
1 file changed, 2 deletions(-)
diff --git a/configure b/configure
index 9f33c7d..e07baf3 100755
--- a/configure
+++ b/configure
@@ -2900,8 +2900,6 @@ EOF
else
coroutine_backend=gthread
fi
- else
- echo "Silently falling back into gthread backend under darwin"
fi
elif test "$coroutine" = "gthread" ; then
coroutine_backend=gthread
--
1.7.11.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Remove stray debug output
2012-10-20 19:37 [Qemu-devel] [PATCH] configure: Remove stray debug output Peter Maydell
@ 2012-10-29 9:54 ` Stefan Hajnoczi
2012-10-29 10:01 ` Peter Maydell
2012-11-16 14:28 ` Stefan Hajnoczi
1 sibling, 1 reply; 4+ messages in thread
From: Stefan Hajnoczi @ 2012-10-29 9:54 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Sat, Oct 20, 2012 at 08:37:04PM +0100, Peter Maydell wrote:
> Rather than printing a message saying we're silently falling
> back to gthread coroutines when running on MacOS, actually
> do it silently.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I guess this is a self-falsifying echo :-)
>
> configure | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/configure b/configure
> index 9f33c7d..e07baf3 100755
> --- a/configure
> +++ b/configure
> @@ -2900,8 +2900,6 @@ EOF
> else
> coroutine_backend=gthread
> fi
> - else
> - echo "Silently falling back into gthread backend under darwin"
> fi
Is there a reason to remove the echo?
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Remove stray debug output
2012-10-29 9:54 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
@ 2012-10-29 10:01 ` Peter Maydell
0 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2012-10-29 10:01 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-trivial, qemu-devel, patches
On 29 October 2012 09:54, Stefan Hajnoczi <stefanha@gmail.com> wrote:
> On Sat, Oct 20, 2012 at 08:37:04PM +0100, Peter Maydell wrote:
>> Rather than printing a message saying we're silently falling
>> back to gthread coroutines when running on MacOS, actually
>> do it silently.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> I guess this is a self-falsifying echo :-)
>>
>> configure | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/configure b/configure
>> index 9f33c7d..e07baf3 100755
>> --- a/configure
>> +++ b/configure
>> @@ -2900,8 +2900,6 @@ EOF
>> else
>> coroutine_backend=gthread
>> fi
>> - else
>> - echo "Silently falling back into gthread backend under darwin"
>> fi
>
> Is there a reason to remove the echo?
1. Nothing else in configure prints progress messages during the
testing phase
2. The echo is by definition printing something that's false
3. We print the chosen coroutine backend at the end as part of
the standard "what did configure do?" output block, so removing
this echo loses no information
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: Remove stray debug output
2012-10-20 19:37 [Qemu-devel] [PATCH] configure: Remove stray debug output Peter Maydell
2012-10-29 9:54 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
@ 2012-11-16 14:28 ` Stefan Hajnoczi
1 sibling, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2012-11-16 14:28 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-trivial, qemu-devel, patches
On Sat, Oct 20, 2012 at 08:37:04PM +0100, Peter Maydell wrote:
> Rather than printing a message saying we're silently falling
> back to gthread coroutines when running on MacOS, actually
> do it silently.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> I guess this is a self-falsifying echo :-)
>
> configure | 2 --
> 1 file changed, 2 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-16 14:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-20 19:37 [Qemu-devel] [PATCH] configure: Remove stray debug output Peter Maydell
2012-10-29 9:54 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
2012-10-29 10:01 ` Peter Maydell
2012-11-16 14:28 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).