* [Qemu-devel] [PATCH] target-sparc: Revert setting cpu_dst to gen_dest_gpr
@ 2012-10-29 4:50 Richard Henderson
2012-10-29 13:54 ` Aurelien Jarno
2012-10-30 21:08 ` Blue Swirl
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2012-10-29 4:50 UTC (permalink / raw)
To: qemu-devel; +Cc: Blue Swirl, Aurelien Jarno
There is some read-after-write error within the OP=2 insns which
prevents setting cpu_dst to the real output register. Until this
is found and fixed, always write to a temporary first.
Cc: Blue Swirl <blauwirbel@gmail.com>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
target-sparc/translate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-sparc/translate.c b/target-sparc/translate.c
index 4321393..9e46f14 100644
--- a/target-sparc/translate.c
+++ b/target-sparc/translate.c
@@ -2633,7 +2633,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn)
case 2: /* FPU & Logical Operations */
{
unsigned int xop = GET_FIELD(insn, 7, 12);
- TCGv cpu_dst = gen_dest_gpr(dc, rd);
+ TCGv cpu_dst = get_temp_tl(dc);
TCGv cpu_tmp0;
if (xop == 0x3a) { /* generate trap */
--
1.7.11.7
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-sparc: Revert setting cpu_dst to gen_dest_gpr
2012-10-29 4:50 [Qemu-devel] [PATCH] target-sparc: Revert setting cpu_dst to gen_dest_gpr Richard Henderson
@ 2012-10-29 13:54 ` Aurelien Jarno
2012-10-30 21:08 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2012-10-29 13:54 UTC (permalink / raw)
To: Richard Henderson; +Cc: Blue Swirl, qemu-devel
On Mon, Oct 29, 2012 at 03:50:20PM +1100, Richard Henderson wrote:
> There is some read-after-write error within the OP=2 insns which
> prevents setting cpu_dst to the real output register. Until this
> is found and fixed, always write to a temporary first.
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> target-sparc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 4321393..9e46f14 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -2633,7 +2633,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn)
> case 2: /* FPU & Logical Operations */
> {
> unsigned int xop = GET_FIELD(insn, 7, 12);
> - TCGv cpu_dst = gen_dest_gpr(dc, rd);
> + TCGv cpu_dst = get_temp_tl(dc);
> TCGv cpu_tmp0;
>
> if (xop == 0x3a) { /* generate trap */
Tested-by: Aurelien Jarno <aurelien@aurel32.net>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] target-sparc: Revert setting cpu_dst to gen_dest_gpr
2012-10-29 4:50 [Qemu-devel] [PATCH] target-sparc: Revert setting cpu_dst to gen_dest_gpr Richard Henderson
2012-10-29 13:54 ` Aurelien Jarno
@ 2012-10-30 21:08 ` Blue Swirl
1 sibling, 0 replies; 3+ messages in thread
From: Blue Swirl @ 2012-10-30 21:08 UTC (permalink / raw)
To: Richard Henderson; +Cc: qemu-devel, Aurelien Jarno
Thanks, applied.
On Mon, Oct 29, 2012 at 4:50 AM, Richard Henderson <rth@twiddle.net> wrote:
> There is some read-after-write error within the OP=2 insns which
> prevents setting cpu_dst to the real output register. Until this
> is found and fixed, always write to a temporary first.
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Cc: Aurelien Jarno <aurelien@aurel32.net>
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
> target-sparc/translate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-sparc/translate.c b/target-sparc/translate.c
> index 4321393..9e46f14 100644
> --- a/target-sparc/translate.c
> +++ b/target-sparc/translate.c
> @@ -2633,7 +2633,7 @@ static void disas_sparc_insn(DisasContext * dc, unsigned int insn)
> case 2: /* FPU & Logical Operations */
> {
> unsigned int xop = GET_FIELD(insn, 7, 12);
> - TCGv cpu_dst = gen_dest_gpr(dc, rd);
> + TCGv cpu_dst = get_temp_tl(dc);
> TCGv cpu_tmp0;
>
> if (xop == 0x3a) { /* generate trap */
> --
> 1.7.11.7
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-30 21:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-29 4:50 [Qemu-devel] [PATCH] target-sparc: Revert setting cpu_dst to gen_dest_gpr Richard Henderson
2012-10-29 13:54 ` Aurelien Jarno
2012-10-30 21:08 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).