From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60219) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTDbL-0005FF-NM for qemu-devel@nongnu.org; Tue, 30 Oct 2012 11:19:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTDbD-0005B6-UL for qemu-devel@nongnu.org; Tue, 30 Oct 2012 11:19:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTDbD-0005As-Me for qemu-devel@nongnu.org; Tue, 30 Oct 2012 11:19:27 -0400 Date: Tue, 30 Oct 2012 11:19:23 -0400 From: Jason Baron Message-ID: <20121030151923.GB2744@redhat.com> References: <66b81e2e5ffe78ac446fe4ba0a28e748595b7bf6.1351561225.git.jbaron@redhat.com> <508F74F2.4060204@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <508F74F2.4060204@redhat.com> Subject: Re: [Qemu-devel] [PATCH v1 12/13] q35: fill in usb pci slots with -usb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: aliguori@us.ibm.com, juzhang@redhat.com, mst@redhat.com, jan.kiszka@siemens.com, qemu-devel@nongnu.org, agraf@suse.de, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, gsomlo@gmail.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, armbru@redhat.com On Tue, Oct 30, 2012 at 07:34:26AM +0100, Gerd Hoffmann wrote: > Hi, > > > + uhci_devname[sizeof(uhci_devname) - 2] = ((char)'1') + i; > > snprintf(devname, sizeof(devname), "...%d", i) is more readable. ok. > > > + qdev_prop_set_string(usb_qdev, "masterbus", "ich9-usb-bus.0"); > > Any reason why you rename the usb bus? > I wasn't sure if the user created usb devices on the command-line via -device if that would break naming here. Thus, I added a 'private' name. If the naming is stable, that works. It would be 'usb-bus.0', in that case? Thanks, -Jason