From: Stefan Hajnoczi <stefanha@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build
Date: Tue, 30 Oct 2012 17:16:45 +0100 [thread overview]
Message-ID: <20121030161645.GB16674@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <20121030140450.GA27739@redhat.com>
On Tue, Oct 30, 2012 at 04:04:50PM +0200, Michael S. Tsirkin wrote:
> Add missing stubs to win32 to fix link failure.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> net/tap-win32.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/net/tap-win32.c b/net/tap-win32.c
> index 22dad3f..8d2d32b 100644
> --- a/net/tap-win32.c
> +++ b/net/tap-win32.c
> @@ -752,3 +752,13 @@ struct vhost_net *tap_get_vhost_net(NetClientState *nc)
> {
> return NULL;
> }
> +
> +int tap_has_vnet_hdr_len(NetClientState *nc, int len)
> +{
> + return 0;
> +}
> +
> +void tap_set_vnet_hdr_len(NetClientState *nc, int len)
> +{
> + assert(0);
> +}
How do we get link failures here on win32? The only object that needs
these functions is vhost_net.o when CONFIG_VHOST_NET is defined.
Stefan
next prev parent reply other threads:[~2012-10-30 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 14:04 [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build Michael S. Tsirkin
2012-10-30 16:16 ` Stefan Hajnoczi [this message]
2012-10-30 16:22 ` Michael S. Tsirkin
2012-10-31 7:19 ` Stefan Hajnoczi
2012-10-30 21:10 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121030161645.GB16674@stefanha-thinkpad.redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).