From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:40558)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TTUY2-00037N-7n
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 05:25:25 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TTUXx-0006uv-Kj
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 05:25:18 -0400
Received: from mx1.redhat.com ([209.132.183.28]:33009)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@redhat.com>) id 1TTUXx-0006ud-CQ
	for qemu-devel@nongnu.org; Wed, 31 Oct 2012 05:25:13 -0400
Date: Wed, 31 Oct 2012 08:19:20 +0100
From: Stefan Hajnoczi <stefanha@redhat.com>
Message-ID: <20121031071920.GA1116@stefanha-thinkpad>
References: <20121030140450.GA27739@redhat.com>
	<20121030161645.GB16674@stefanha-thinkpad.redhat.com>
	<20121030162245.GA7669@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20121030162245.GA7669@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Tue, Oct 30, 2012 at 06:22:45PM +0200, Michael S. Tsirkin wrote:
> On Tue, Oct 30, 2012 at 05:16:45PM +0100, Stefan Hajnoczi wrote:
> > On Tue, Oct 30, 2012 at 04:04:50PM +0200, Michael S. Tsirkin wrote:
> > > Add missing stubs to win32 to fix link failure.
> > > 
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> > > ---
> > >  net/tap-win32.c | 10 ++++++++++
> > >  1 file changed, 10 insertions(+)
> > > 
> > > diff --git a/net/tap-win32.c b/net/tap-win32.c
> > > index 22dad3f..8d2d32b 100644
> > > --- a/net/tap-win32.c
> > > +++ b/net/tap-win32.c
> > > @@ -752,3 +752,13 @@ struct vhost_net *tap_get_vhost_net(NetClientState *nc)
> > >  {
> > >      return NULL;
> > >  }
> > > +
> > > +int tap_has_vnet_hdr_len(NetClientState *nc, int len)
> > > +{
> > > +    return 0;
> > > +}
> > > +
> > > +void tap_set_vnet_hdr_len(NetClientState *nc, int len)
> > > +{
> > > +    assert(0);
> > > +}
> > 
> > How do we get link failures here on win32?  The only object that needs
> > these functions is vhost_net.o when CONFIG_VHOST_NET is defined.
> > 
> > Stefan
> 
> No, virtio-net uses them too.

Weird, git-grep(1) on qemu.git/master doesn't show calls to these
functions from anywhere other than vhost_net.o.

Stefan