* [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build
@ 2012-10-30 14:04 Michael S. Tsirkin
2012-10-30 16:16 ` Stefan Hajnoczi
2012-10-30 21:10 ` Blue Swirl
0 siblings, 2 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2012-10-30 14:04 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini, Anthony Liguori, Stefan Hajnoczi
Add missing stubs to win32 to fix link failure.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reported-by: Paolo Bonzini <pbonzini@redhat.com>
---
net/tap-win32.c | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/net/tap-win32.c b/net/tap-win32.c
index 22dad3f..8d2d32b 100644
--- a/net/tap-win32.c
+++ b/net/tap-win32.c
@@ -752,3 +752,13 @@ struct vhost_net *tap_get_vhost_net(NetClientState *nc)
{
return NULL;
}
+
+int tap_has_vnet_hdr_len(NetClientState *nc, int len)
+{
+ return 0;
+}
+
+void tap_set_vnet_hdr_len(NetClientState *nc, int len)
+{
+ assert(0);
+}
--
MST
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build
2012-10-30 14:04 [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build Michael S. Tsirkin
@ 2012-10-30 16:16 ` Stefan Hajnoczi
2012-10-30 16:22 ` Michael S. Tsirkin
2012-10-30 21:10 ` Blue Swirl
1 sibling, 1 reply; 5+ messages in thread
From: Stefan Hajnoczi @ 2012-10-30 16:16 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
On Tue, Oct 30, 2012 at 04:04:50PM +0200, Michael S. Tsirkin wrote:
> Add missing stubs to win32 to fix link failure.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> net/tap-win32.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/net/tap-win32.c b/net/tap-win32.c
> index 22dad3f..8d2d32b 100644
> --- a/net/tap-win32.c
> +++ b/net/tap-win32.c
> @@ -752,3 +752,13 @@ struct vhost_net *tap_get_vhost_net(NetClientState *nc)
> {
> return NULL;
> }
> +
> +int tap_has_vnet_hdr_len(NetClientState *nc, int len)
> +{
> + return 0;
> +}
> +
> +void tap_set_vnet_hdr_len(NetClientState *nc, int len)
> +{
> + assert(0);
> +}
How do we get link failures here on win32? The only object that needs
these functions is vhost_net.o when CONFIG_VHOST_NET is defined.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build
2012-10-30 16:16 ` Stefan Hajnoczi
@ 2012-10-30 16:22 ` Michael S. Tsirkin
2012-10-31 7:19 ` Stefan Hajnoczi
0 siblings, 1 reply; 5+ messages in thread
From: Michael S. Tsirkin @ 2012-10-30 16:22 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
On Tue, Oct 30, 2012 at 05:16:45PM +0100, Stefan Hajnoczi wrote:
> On Tue, Oct 30, 2012 at 04:04:50PM +0200, Michael S. Tsirkin wrote:
> > Add missing stubs to win32 to fix link failure.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> > ---
> > net/tap-win32.c | 10 ++++++++++
> > 1 file changed, 10 insertions(+)
> >
> > diff --git a/net/tap-win32.c b/net/tap-win32.c
> > index 22dad3f..8d2d32b 100644
> > --- a/net/tap-win32.c
> > +++ b/net/tap-win32.c
> > @@ -752,3 +752,13 @@ struct vhost_net *tap_get_vhost_net(NetClientState *nc)
> > {
> > return NULL;
> > }
> > +
> > +int tap_has_vnet_hdr_len(NetClientState *nc, int len)
> > +{
> > + return 0;
> > +}
> > +
> > +void tap_set_vnet_hdr_len(NetClientState *nc, int len)
> > +{
> > + assert(0);
> > +}
>
> How do we get link failures here on win32? The only object that needs
> these functions is vhost_net.o when CONFIG_VHOST_NET is defined.
>
> Stefan
No, virtio-net uses them too.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build
2012-10-30 16:22 ` Michael S. Tsirkin
@ 2012-10-31 7:19 ` Stefan Hajnoczi
0 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2012-10-31 7:19 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Paolo Bonzini, Anthony Liguori, qemu-devel
On Tue, Oct 30, 2012 at 06:22:45PM +0200, Michael S. Tsirkin wrote:
> On Tue, Oct 30, 2012 at 05:16:45PM +0100, Stefan Hajnoczi wrote:
> > On Tue, Oct 30, 2012 at 04:04:50PM +0200, Michael S. Tsirkin wrote:
> > > Add missing stubs to win32 to fix link failure.
> > >
> > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > > Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> > > ---
> > > net/tap-win32.c | 10 ++++++++++
> > > 1 file changed, 10 insertions(+)
> > >
> > > diff --git a/net/tap-win32.c b/net/tap-win32.c
> > > index 22dad3f..8d2d32b 100644
> > > --- a/net/tap-win32.c
> > > +++ b/net/tap-win32.c
> > > @@ -752,3 +752,13 @@ struct vhost_net *tap_get_vhost_net(NetClientState *nc)
> > > {
> > > return NULL;
> > > }
> > > +
> > > +int tap_has_vnet_hdr_len(NetClientState *nc, int len)
> > > +{
> > > + return 0;
> > > +}
> > > +
> > > +void tap_set_vnet_hdr_len(NetClientState *nc, int len)
> > > +{
> > > + assert(0);
> > > +}
> >
> > How do we get link failures here on win32? The only object that needs
> > these functions is vhost_net.o when CONFIG_VHOST_NET is defined.
> >
> > Stefan
>
> No, virtio-net uses them too.
Weird, git-grep(1) on qemu.git/master doesn't show calls to these
functions from anywhere other than vhost_net.o.
Stefan
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build
2012-10-30 14:04 [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build Michael S. Tsirkin
2012-10-30 16:16 ` Stefan Hajnoczi
@ 2012-10-30 21:10 ` Blue Swirl
1 sibling, 0 replies; 5+ messages in thread
From: Blue Swirl @ 2012-10-30 21:10 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: Paolo Bonzini, Anthony Liguori, qemu-devel, Stefan Hajnoczi
Thanks, applied.
On Tue, Oct 30, 2012 at 2:04 PM, Michael S. Tsirkin <mst@redhat.com> wrote:
> Add missing stubs to win32 to fix link failure.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> Reported-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
> net/tap-win32.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/net/tap-win32.c b/net/tap-win32.c
> index 22dad3f..8d2d32b 100644
> --- a/net/tap-win32.c
> +++ b/net/tap-win32.c
> @@ -752,3 +752,13 @@ struct vhost_net *tap_get_vhost_net(NetClientState *nc)
> {
> return NULL;
> }
> +
> +int tap_has_vnet_hdr_len(NetClientState *nc, int len)
> +{
> + return 0;
> +}
> +
> +void tap_set_vnet_hdr_len(NetClientState *nc, int len)
> +{
> + assert(0);
> +}
> --
> MST
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-10-31 9:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-30 14:04 [Qemu-devel] [PATCH] tap-win32: stubs to fix win32 build Michael S. Tsirkin
2012-10-30 16:16 ` Stefan Hajnoczi
2012-10-30 16:22 ` Michael S. Tsirkin
2012-10-31 7:19 ` Stefan Hajnoczi
2012-10-30 21:10 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).