From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTTh3-0002dz-GH for qemu-devel@nongnu.org; Wed, 31 Oct 2012 04:30:37 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTTgu-0000I3-UD for qemu-devel@nongnu.org; Wed, 31 Oct 2012 04:30:33 -0400 Received: from mail-bk0-f45.google.com ([209.85.214.45]:34876) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTTgu-0000HO-Hq for qemu-devel@nongnu.org; Wed, 31 Oct 2012 04:30:24 -0400 Received: by mail-bk0-f45.google.com with SMTP id jf3so439447bkc.4 for ; Wed, 31 Oct 2012 01:30:24 -0700 (PDT) Date: Wed, 31 Oct 2012 09:12:24 +0100 From: Stefan Hajnoczi Message-ID: <20121031081224.GE1116@stefanha-thinkpad> References: <1351343715-7446-1-git-send-email-mjt@msgid.tls.msk.ru> <20121029091841.GD8917@stefanha-thinkpad.redhat.com> <508E7612.9070306@msgid.tls.msk.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <508E7612.9070306@msgid.tls.msk.ru> Subject: Re: [Qemu-devel] [PATCH] disallow -daemonize usage of stdio (curses display, -nographic, -serial stdio etc) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Blue Swirl , Peter Maydell , Hitoshi Mitake , qemu-devel@nongnu.org, Anthony Liguori On Mon, Oct 29, 2012 at 04:26:58PM +0400, Michael Tokarev wrote: > 29.10.2012 13:18, Stefan Hajnoczi wrote: > > On Sat, Oct 27, 2012 at 05:15:15PM +0400, Michael Tokarev wrote: > >> diff --git a/vl.c b/vl.c > >> index 9f99ef4..db48d62 100644 > >> --- a/vl.c > >> +++ b/vl.c > >> @@ -3413,6 +3413,26 @@ int main(int argc, char **argv, char **envp) > >> default_sdcard = 0; > >> } > >> > >> + if (is_daemonized()) { > >> + /* According to documentation and historically, -nographic redirects > >> + * serial port, parallel port and monitor to stdio, which does not work > >> + * with -daemonize. We can redirect these to null instead, but since > >> + * -nographic is legacy, let's just error out. > >> + */ > >> + if (display_type == DT_NOGRAPHIC > >> + /* && (default_parallel || default_serial > >> + || default_monitor || default_virtcon) */) { > > > > Uncomment these? > > I'd say treat it as a documentation comment, sort of. > If all 4 other options are specified, -nographics has > no effect, so this very case is not very interesting -- > once you specify all 4, you don't need -nographic. > But keeping this special case around makes behavour > less consistent: -nographic starts sometimes working > and sometimes not. In that case I suggest we remove it or replace it with a comment in English. Commented out code usually confuses me more than helps, as this example shows :). Stefan