From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44488) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTV8P-0005uX-FA for qemu-devel@nongnu.org; Wed, 31 Oct 2012 06:02:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTV8F-0001Yk-EY for qemu-devel@nongnu.org; Wed, 31 Oct 2012 06:02:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12231) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTV8F-0001Yg-64 for qemu-devel@nongnu.org; Wed, 31 Oct 2012 06:02:43 -0400 Date: Wed, 31 Oct 2012 12:04:58 +0200 From: "Michael S. Tsirkin" Message-ID: <20121031100458.GE12521@redhat.com> References: <2be648d47fa2cfb210c18dda0a3fb03cffd621e1.1351561225.git.jbaron@redhat.com> <87zk33u5ud.fsf@codemonkey.ws> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87zk33u5ud.fsf@codemonkey.ws> Subject: Re: [Qemu-devel] [PATCH v1 07/13] q35: Introduce q35 pc based chipset emulator List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: agraf@suse.de, juzhang@redhat.com, jan.kiszka@siemens.com, Jason Baron , qemu-devel@nongnu.org, armbru@redhat.com, blauwirbel@gmail.com, yamahata@valinux.co.jp, alex.williamson@redhat.com, kevin@koconnor.net, avi@redhat.com, mkletzan@redhat.com, pbonzini@redhat.com, lcapitulino@redhat.com, afaerber@suse.de, kraxel@redhat.com On Tue, Oct 30, 2012 at 02:18:02PM -0500, Anthony Liguori wrote: > Jason Baron writes: > > > From: Isaku Yamahata > > > > pc q35 based chipset emulator to support pci express natively. Based on > > Anthony Liguori's suggestion, the machine name is 'q35-next', with an alias > > of 'q35'. At this point, there are no compatibility guarantees. When the > > chipset stabilizes more, we will begin to version the machine names. > > > > Major features which still need to be added: > > > > -Migration support (mostly around ahci) > > -ACPI hotplug support (pcie hotplug support is working) > > -Passthrough support > > > > Signed-off-by: Isaku Yamahata > > Signed-off-by: Jason Baron > > --- > > hw/i386/Makefile.objs | 2 +- > > hw/pc.h | 2 + > > hw/pc_piix.c | 4 +- > > hw/pc_q35.c | 326 +++++++++++++++++++++++++++++++++++++++++++++++++ > > hw/pci_ids.h | 2 + > > hw/q35.c | 315 +++++++++++++++++++++++++++++++++++++++++++++++ > > hw/q35.h | 161 ++++++++++++++++++++++++ > > 7 files changed, 809 insertions(+), 3 deletions(-) > > create mode 100644 hw/pc_q35.c > > create mode 100644 hw/q35.c > > create mode 100644 hw/q35.h > > > > diff --git a/hw/i386/Makefile.objs b/hw/i386/Makefile.objs > > index 693bd18..469b127 100644 > > --- a/hw/i386/Makefile.objs > > +++ b/hw/i386/Makefile.objs > > @@ -7,7 +7,7 @@ obj-y += debugcon.o multiboot.o > > obj-y += pc_piix.o > > obj-y += pc_sysfw.o > > obj-y += pam.o > > -obj-y += acpi_ich9.o lpc_ich9.o smbus_ich9.o > > +obj-y += acpi_ich9.o lpc_ich9.o smbus_ich9.o q35.o pc_q35.o > > This shouldn't be here. It should be in hw/Makefile.objs. > > This is not target specific code. What about acpi_ich9.o lpc_ich9.o smbus_ich9.o? Should it move to Makefile.objs too? How is this different from pc_piix? -- MST