qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Aurelien Jarno <aurelien@aurel32.net>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] target-alpha: Use TCG_CALL_NO_WG
Date: Wed, 31 Oct 2012 21:45:16 +0100	[thread overview]
Message-ID: <20121031204516.GC31495@ohm.aurel32.net> (raw)
In-Reply-To: <1351639855-32629-1-git-send-email-rth@twiddle.net>

On Wed, Oct 31, 2012 at 10:30:55AM +1100, Richard Henderson wrote:
> Mark helper functions that raise exceptions, but otherwise do not
> change TCG register state, with TCG_CALL_NO_WG.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>
> ---
>  target-alpha/helper.h | 20 ++++++++++----------
>  1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/target-alpha/helper.h b/target-alpha/helper.h
> index 162816f..dd55f89 100644
> --- a/target-alpha/helper.h
> +++ b/target-alpha/helper.h
> @@ -3,12 +3,12 @@
>  DEF_HELPER_3(excp, noreturn, env, int, int)
>  DEF_HELPER_FLAGS_1(load_pcc, TCG_CALL_NO_RWG_SE, i64, env)
>  
> -DEF_HELPER_3(addqv, i64, env, i64, i64)
> -DEF_HELPER_3(addlv, i64, env, i64, i64)
> -DEF_HELPER_3(subqv, i64, env, i64, i64)
> -DEF_HELPER_3(sublv, i64, env, i64, i64)
> -DEF_HELPER_3(mullv, i64, env, i64, i64)
> -DEF_HELPER_3(mulqv, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(addqv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(addlv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(subqv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(sublv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(mullv, TCG_CALL_NO_WG, i64, env, i64, i64)
> +DEF_HELPER_FLAGS_3(mulqv, TCG_CALL_NO_WG, i64, env, i64, i64)
>  DEF_HELPER_FLAGS_2(umulh, TCG_CALL_NO_RWG_SE, i64, i64, i64)
>  
>  DEF_HELPER_FLAGS_1(ctpop, TCG_CALL_NO_RWG_SE, i64, i64)
> @@ -92,11 +92,11 @@ DEF_HELPER_FLAGS_2(setroundmode, TCG_CALL_NO_RWG, void, env, i32)
>  DEF_HELPER_FLAGS_2(setflushzero, TCG_CALL_NO_RWG, void, env, i32)
>  DEF_HELPER_FLAGS_1(fp_exc_clear, TCG_CALL_NO_RWG, void, env)
>  DEF_HELPER_FLAGS_1(fp_exc_get, TCG_CALL_NO_RWG_SE, i32, env)
> -DEF_HELPER_3(fp_exc_raise, void, env, i32, i32)
> -DEF_HELPER_3(fp_exc_raise_s, void, env, i32, i32)
> +DEF_HELPER_FLAGS_3(fp_exc_raise, TCG_CALL_NO_WG, void, env, i32, i32)
> +DEF_HELPER_FLAGS_3(fp_exc_raise_s, TCG_CALL_NO_WG, void, env, i32, i32)
>  
> -DEF_HELPER_2(ieee_input, void, env, i64)
> -DEF_HELPER_2(ieee_input_cmp, void, env, i64)
> +DEF_HELPER_FLAGS_2(ieee_input, TCG_CALL_NO_WG, void, env, i64)
> +DEF_HELPER_FLAGS_2(ieee_input_cmp, TCG_CALL_NO_WG, void, env, i64)
>  
>  #if !defined (CONFIG_USER_ONLY)
>  DEF_HELPER_2(hw_ret, void, env, i64)

Reviewed-by: Aurelien Jarno <aurelien@aurel32.net>

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

      reply	other threads:[~2012-10-31 20:45 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-30 23:30 [Qemu-devel] [PATCH] target-alpha: Use TCG_CALL_NO_WG Richard Henderson
2012-10-31 20:45 ` Aurelien Jarno [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121031204516.GC31495@ohm.aurel32.net \
    --to=aurelien@aurel32.net \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).