* [Qemu-devel] [PATCH] net: fix bug in net_init_socket
@ 2012-11-01 9:39 Lei Li
2012-11-01 10:05 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Lei Li @ 2012-11-01 9:39 UTC (permalink / raw)
To: qemu-devel; +Cc: Lei Li
Fix the problem that can not delete the udp socket.
It's caused by passing "udp" model to net_socket_udp_init,
but we do not have "udp" model in our model list.
Pass the right model "socket" to init function.
https://bugs.launchpad.net/qemu/+bug/1073585?comments=all
Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
net/socket.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/net/socket.c b/net/socket.c
index b75d567..c01323d 100644
--- a/net/socket.c
+++ b/net/socket.c
@@ -747,7 +747,7 @@ int net_init_socket(const NetClientOptions *opts, const char *name,
error_report("localaddr= is mandatory with udp=");
return -1;
}
- if (net_socket_udp_init(peer, "udp", name, sock->udp, sock->localaddr) ==
+ if (net_socket_udp_init(peer, "socket", name, sock->udp, sock->localaddr) ==
-1) {
return -1;
}
--
1.7.7.6
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] net: fix bug in net_init_socket
2012-11-01 9:39 [Qemu-devel] [PATCH] net: fix bug in net_init_socket Lei Li
@ 2012-11-01 10:05 ` Stefan Hajnoczi
2012-11-02 2:11 ` Lei Li
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-11-01 10:05 UTC (permalink / raw)
To: Lei Li; +Cc: qemu-devel
On Thu, Nov 01, 2012 at 05:39:55PM +0800, Lei Li wrote:
> Fix the problem that can not delete the udp socket.
> It's caused by passing "udp" model to net_socket_udp_init,
> but we do not have "udp" model in our model list.
> Pass the right model "socket" to init function.
>
> https://bugs.launchpad.net/qemu/+bug/1073585?comments=all
>
> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
> ---
> net/socket.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Thanks, applied to the net tree:
https://github.com/stefanha/qemu/commits/net
I changed the commit message from 'fix bug in net_init_socket' to 'use
"socket" model name for UDP sockets' to be more specific.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] net: fix bug in net_init_socket
2012-11-01 10:05 ` Stefan Hajnoczi
@ 2012-11-02 2:11 ` Lei Li
0 siblings, 0 replies; 3+ messages in thread
From: Lei Li @ 2012-11-02 2:11 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel
On 11/01/2012 06:05 PM, Stefan Hajnoczi wrote:
> On Thu, Nov 01, 2012 at 05:39:55PM +0800, Lei Li wrote:
>> Fix the problem that can not delete the udp socket.
>> It's caused by passing "udp" model to net_socket_udp_init,
>> but we do not have "udp" model in our model list.
>> Pass the right model "socket" to init function.
>>
>> https://bugs.launchpad.net/qemu/+bug/1073585?comments=all
>>
>> Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
>> ---
>> net/socket.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
> Thanks, applied to the net tree:
> https://github.com/stefanha/qemu/commits/net
>
> I changed the commit message from 'fix bug in net_init_socket' to 'use
> "socket" model name for UDP sockets' to be more specific.
Sure, thanks. :)
>
> Stefan
>
--
Lei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-02 2:15 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-01 9:39 [Qemu-devel] [PATCH] net: fix bug in net_init_socket Lei Li
2012-11-01 10:05 ` Stefan Hajnoczi
2012-11-02 2:11 ` Lei Li
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).