From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del()
Date: Thu, 1 Nov 2012 11:06:26 +0100 [thread overview]
Message-ID: <20121101100626.GA20508@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1351082052-13387-1-git-send-email-stefanha@redhat.com>
On Wed, Oct 24, 2012 at 02:34:12PM +0200, Stefan Hajnoczi wrote:
> The netdev_del command crashes when given a -net device, because it
> calls qemu_opts_del(NULL).
>
> Check that this is a -netdev before attempting to delete it and the
> QemuOpts.
>
> Note the subtle change from qemu_find_opts_err("netdev", errp) to
> qemu_find_opts_err("netdev", NULL). Since "netdev" is a built in
> options group and we don't check for NULL return anyway, there's no use
> in passing errp here.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> net.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
Applied to the net tree:
https://github.com/stefanha/qemu/commits/net
Stefan
prev parent reply other threads:[~2012-11-01 10:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-24 12:34 [Qemu-devel] [PATCH] net: Reject non-netdevs in qmp_netdev_del() Stefan Hajnoczi
2012-11-01 10:06 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121101100626.GA20508@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).