From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU72n-0002a4-7u for qemu-devel@nongnu.org; Thu, 01 Nov 2012 22:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TU72j-0007rB-Dt for qemu-devel@nongnu.org; Thu, 01 Nov 2012 22:31:37 -0400 Date: Fri, 2 Nov 2012 13:12:32 +1100 From: David Gibson Message-ID: <20121102021232.GL27695@truffula.fritz.box> References: <1351567512-17278-1-git-send-email-david@gibson.dropbear.id.au> <1351567512-17278-6-git-send-email-david@gibson.dropbear.id.au> <00AE8994-0C16-488C-A005-561E1841F317@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <00AE8994-0C16-488C-A005-561E1841F317@suse.de> Subject: Re: [Qemu-devel] [PATCH 05/16] pseries: Use #define for XICS base irq number List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Michael Ellerman , qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Thu, Nov 01, 2012 at 11:15:43AM +0100, Alexander Graf wrote: > > On 30.10.2012, at 04:25, David Gibson wrote: > > > From: Ben Herrenschmidt > > > > Currently the lowest "real" irq number for the XICS irq controller (as > > opposed to numbers reserved for IPIs and other special purposes) is > > hard coded as 16 in two places - in xics_system_init() and in spapr.c. > > > > As well as being generally bad practice, we're going to need to change this > > number soon to fit in with the in-kernel XICS implementation. This patch > > adds a #define for this number to avoid future breakage. > > > > Signed-off-by: Michael Ellerman > > Signed-off-by: Ben Herrenschmidt > > From: and Signed-off fields seem to not match. Well.. it's a fuzzy case in signed-off practice. Both Michael and Ben have worked on the patch, Michael first. I then split the patch up for submission and had to make a judgement call as to who was the main author of that section. My best guess on the available information was Ben. Michael, Ben, have anything to add? -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson