From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TVFgz-0003TL-IP for qemu-devel@nongnu.org; Mon, 05 Nov 2012 00:57:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TVFgy-0001QT-LK for qemu-devel@nongnu.org; Mon, 05 Nov 2012 00:57:49 -0500 Date: Mon, 5 Nov 2012 06:57:39 +0100 From: Stefan Hajnoczi Message-ID: <20121105055739.GA2452@stefanha-thinkpad.redhat.com> References: <1352027374-30796-1-git-send-email-sw@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1352027374-30796-1-git-send-email-sw@weilnetz.de> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Workaround for older versions of MinGW gcc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, Kevin Wolf , qemu-devel@nongnu.org, Paolo Bonzini On Sun, Nov 04, 2012 at 12:09:34PM +0100, Stefan Weil wrote: > Versions before gcc-4.6 don't support unnamed fields in initializers > (see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676). > > Offset and OffsetHigh belong to an unnamed struct which is part of an > unnamed union. Therefore the original code does not work with older > versions of gcc. > > Signed-off-by: Stefan Weil > --- > > This patch is needed for Debian's amd64-mingw32msvc-gcc-4.4.4 > which I use for MinGW-w64 cross compilation. > > Regards > Stefan W. > > block/win32-aio.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Reviewed-by: Stefan Hajnoczi