* [Qemu-devel] [PATCH] target-mips: use ULL for 64 bit constants
@ 2012-11-03 18:48 Blue Swirl
2012-11-05 7:03 ` Aurelien Jarno
0 siblings, 1 reply; 2+ messages in thread
From: Blue Swirl @ 2012-11-03 18:48 UTC (permalink / raw)
To: qemu-devel; +Cc: blauwirbel, Aurelien Jarno
Fix build on a 32 bit host:
CC mips-softmmu/target-mips/dsp_helper.o
/src/qemu/target-mips/dsp_helper.c: In function 'helper_dextr_rs_w':
/src/qemu/target-mips/dsp_helper.c:3556: error: integer constant is too large for 'long' type
/src/qemu/target-mips/dsp_helper.c: In function 'helper_extr_s_h':
/src/qemu/target-mips/dsp_helper.c:3656: error: integer constant is too large for 'long' type
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
---
target-mips/dsp_helper.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
index b59133e..e7949c2 100644
--- a/target-mips/dsp_helper.c
+++ b/target-mips/dsp_helper.c
@@ -3553,7 +3553,7 @@ target_ulong helper_dextr_rs_w(target_ulong ac, target_ulong shift,
if (temp128 == 0) {
temp[0] = 0x0FFFFFFFF;
} else {
- temp[0] = 0x0100000000;
+ temp[0] = 0x0100000000ULL;
}
set_DSPControl_overflow_flag(1, 23, env);
}
@@ -3653,7 +3653,7 @@ target_ulong helper_extr_s_h(target_ulong ac, target_ulong shift,
if (temp > (int64_t)0x7FFF) {
temp = 0x00007FFF;
set_DSPControl_overflow_flag(1, 23, env);
- } else if (temp < (int64_t)0xFFFFFFFFFFFF8000) {
+ } else if (temp < (int64_t)0xFFFFFFFFFFFF8000ULL) {
temp = 0xFFFF8000;
set_DSPControl_overflow_flag(1, 23, env);
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] target-mips: use ULL for 64 bit constants
2012-11-03 18:48 [Qemu-devel] [PATCH] target-mips: use ULL for 64 bit constants Blue Swirl
@ 2012-11-05 7:03 ` Aurelien Jarno
0 siblings, 0 replies; 2+ messages in thread
From: Aurelien Jarno @ 2012-11-05 7:03 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
On Sat, Nov 03, 2012 at 06:48:35PM +0000, Blue Swirl wrote:
> Fix build on a 32 bit host:
> CC mips-softmmu/target-mips/dsp_helper.o
> /src/qemu/target-mips/dsp_helper.c: In function 'helper_dextr_rs_w':
> /src/qemu/target-mips/dsp_helper.c:3556: error: integer constant is too large for 'long' type
> /src/qemu/target-mips/dsp_helper.c: In function 'helper_extr_s_h':
> /src/qemu/target-mips/dsp_helper.c:3656: error: integer constant is too large for 'long' type
>
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
> target-mips/dsp_helper.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
> index b59133e..e7949c2 100644
> --- a/target-mips/dsp_helper.c
> +++ b/target-mips/dsp_helper.c
> @@ -3553,7 +3553,7 @@ target_ulong helper_dextr_rs_w(target_ulong ac, target_ulong shift,
> if (temp128 == 0) {
> temp[0] = 0x0FFFFFFFF;
> } else {
> - temp[0] = 0x0100000000;
> + temp[0] = 0x0100000000ULL;
> }
> set_DSPControl_overflow_flag(1, 23, env);
> }
> @@ -3653,7 +3653,7 @@ target_ulong helper_extr_s_h(target_ulong ac, target_ulong shift,
> if (temp > (int64_t)0x7FFF) {
> temp = 0x00007FFF;
> set_DSPControl_overflow_flag(1, 23, env);
> - } else if (temp < (int64_t)0xFFFFFFFFFFFF8000) {
> + } else if (temp < (int64_t)0xFFFFFFFFFFFF8000ULL) {
> temp = 0xFFFF8000;
> set_DSPControl_overflow_flag(1, 23, env);
> }
Thanks, applied.
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-05 7:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-03 18:48 [Qemu-devel] [PATCH] target-mips: use ULL for 64 bit constants Blue Swirl
2012-11-05 7:03 ` Aurelien Jarno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).