From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:60069)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TVGir-0002Dl-UY
	for qemu-devel@nongnu.org; Mon, 05 Nov 2012 02:03:50 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TVGiq-0007dq-O3
	for qemu-devel@nongnu.org; Mon, 05 Nov 2012 02:03:49 -0500
Received: from hall.aurel32.net ([2001:470:1f15:c4f::1]:49801)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1TVGiq-0007dk-Gz
	for qemu-devel@nongnu.org; Mon, 05 Nov 2012 02:03:48 -0500
Date: Mon, 5 Nov 2012 08:03:40 +0100
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20121105070340.GH31495@ohm.aurel32.net>
References: <1352060975-18646-1-git-send-email-sw@weilnetz.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <1352060975-18646-1-git-send-email-sw@weilnetz.de>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Fix compiler warnings caused
 by very large constants
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org

On Sun, Nov 04, 2012 at 09:29:35PM +0100, Stefan Weil wrote:
> Those constants are larger than 32 bits and need a suffix to avoid
> warnings from some versions of gcc.
> 
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
>  target-mips/dsp_helper.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c
> index b59133e..2ab9956 100644
> --- a/target-mips/dsp_helper.c
> +++ b/target-mips/dsp_helper.c
> @@ -3553,7 +3553,7 @@ target_ulong helper_dextr_rs_w(target_ulong ac, target_ulong shift,
>          if (temp128 == 0) {
>              temp[0] = 0x0FFFFFFFF;
>          } else {
> -            temp[0] = 0x0100000000;
> +            temp[0] = 0x0100000000ULL;
>          }
>          set_DSPControl_overflow_flag(1, 23, env);
>      }
> @@ -3653,7 +3653,7 @@ target_ulong helper_extr_s_h(target_ulong ac, target_ulong shift,
>      if (temp > (int64_t)0x7FFF) {
>          temp = 0x00007FFF;
>          set_DSPControl_overflow_flag(1, 23, env);
> -    } else if (temp < (int64_t)0xFFFFFFFFFFFF8000) {
> +    } else if (temp < (int64_t)0xFFFFFFFFFFFF8000LL) {
>          temp = 0xFFFF8000;
>          set_DSPControl_overflow_flag(1, 23, env);
>      }

Blue Swirl proposed the same patch a bit earlier then you, and I have
just applied it.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net