From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: David Holsgrove <david.holsgrove@xilinx.com>,
qemu-devel@nongnu.org, git@xilinx.com
Subject: Re: [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decoding
Date: Fri, 9 Nov 2012 11:40:53 +0100 [thread overview]
Message-ID: <20121109104053.GA6687@edde.se.axis.com> (raw)
In-Reply-To: <1352347279-769-1-git-send-email-peter.crosthwaite@xilinx.com>
On Thu, Nov 08, 2012 at 02:01:19PM +1000, Peter Crosthwaite wrote:
> The swaph instruction was not decoding correctly. s/1e1/1e2 on the
> 9 LSBs on the instruction decode.
>
> Reported-by: David Holsgrove <david.holsgrove@xilinx.com>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> target-microblaze/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 7d864b1..6f27c24 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -840,7 +840,7 @@ static void dec_bit(DisasContext *dc)
> LOG_DIS("swapb r%d r%d\n", dc->rd, dc->ra);
> tcg_gen_bswap32_i32(cpu_R[dc->rd], cpu_R[dc->ra]);
> break;
> - case 0x1e1:
> + case 0x1e2:
Ouch.. I've applied the fix, thanks.
David, was this the bug that was causing the recent errors with the rebased
GCC port?
Cheers,
Edgar
prev parent reply other threads:[~2012-11-09 10:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-08 4:01 [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decoding Peter Crosthwaite
2012-11-09 10:40 ` Edgar E. Iglesias [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121109104053.GA6687@edde.se.axis.com \
--to=edgar.iglesias@gmail.com \
--cc=david.holsgrove@xilinx.com \
--cc=git@xilinx.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).