* [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decoding
@ 2012-11-08 4:01 Peter Crosthwaite
2012-11-09 10:40 ` Edgar E. Iglesias
0 siblings, 1 reply; 2+ messages in thread
From: Peter Crosthwaite @ 2012-11-08 4:01 UTC (permalink / raw)
To: qemu-devel, edgar.iglesias; +Cc: Peter Crosthwaite, git
The swaph instruction was not decoding correctly. s/1e1/1e2 on the
9 LSBs on the instruction decode.
Reported-by: David Holsgrove <david.holsgrove@xilinx.com>
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
target-microblaze/translate.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
index 7d864b1..6f27c24 100644
--- a/target-microblaze/translate.c
+++ b/target-microblaze/translate.c
@@ -840,7 +840,7 @@ static void dec_bit(DisasContext *dc)
LOG_DIS("swapb r%d r%d\n", dc->rd, dc->ra);
tcg_gen_bswap32_i32(cpu_R[dc->rd], cpu_R[dc->ra]);
break;
- case 0x1e1:
+ case 0x1e2:
/*swaph */
LOG_DIS("swaph r%d r%d\n", dc->rd, dc->ra);
tcg_gen_rotri_i32(cpu_R[dc->rd], cpu_R[dc->ra], 16);
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decoding
2012-11-08 4:01 [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decoding Peter Crosthwaite
@ 2012-11-09 10:40 ` Edgar E. Iglesias
0 siblings, 0 replies; 2+ messages in thread
From: Edgar E. Iglesias @ 2012-11-09 10:40 UTC (permalink / raw)
To: Peter Crosthwaite; +Cc: David Holsgrove, qemu-devel, git
On Thu, Nov 08, 2012 at 02:01:19PM +1000, Peter Crosthwaite wrote:
> The swaph instruction was not decoding correctly. s/1e1/1e2 on the
> 9 LSBs on the instruction decode.
>
> Reported-by: David Holsgrove <david.holsgrove@xilinx.com>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> target-microblaze/translate.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 7d864b1..6f27c24 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -840,7 +840,7 @@ static void dec_bit(DisasContext *dc)
> LOG_DIS("swapb r%d r%d\n", dc->rd, dc->ra);
> tcg_gen_bswap32_i32(cpu_R[dc->rd], cpu_R[dc->ra]);
> break;
> - case 0x1e1:
> + case 0x1e2:
Ouch.. I've applied the fix, thanks.
David, was this the bug that was causing the recent errors with the rebased
GCC port?
Cheers,
Edgar
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-09 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-08 4:01 [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph decoding Peter Crosthwaite
2012-11-09 10:40 ` Edgar E. Iglesias
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).