From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58524)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1TWm1G-0008Ve-62
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 05:41:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1TWm1C-0004uc-4z
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 05:41:02 -0500
Received: from mail-la0-f45.google.com ([209.85.215.45]:55618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <edgar.iglesias@gmail.com>) id 1TWm1B-0004uS-TM
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 05:40:58 -0500
Received: by mail-la0-f45.google.com with SMTP id m13so2683811lah.4
	for <qemu-devel@nongnu.org>; Fri, 09 Nov 2012 02:40:56 -0800 (PST)
Date: Fri, 9 Nov 2012 11:40:53 +0100
From: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>
Message-ID: <20121109104053.GA6687@edde.se.axis.com>
References: <1352347279-769-1-git-send-email-peter.crosthwaite@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1352347279-769-1-git-send-email-peter.crosthwaite@xilinx.com>
Subject: Re: [Qemu-devel] [QEMU PATCH] microblaze: translate.c: Fix swaph
	decoding
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Cc: David Holsgrove <david.holsgrove@xilinx.com>, qemu-devel@nongnu.org, git@xilinx.com

On Thu, Nov 08, 2012 at 02:01:19PM +1000, Peter Crosthwaite wrote:
> The swaph instruction was not decoding correctly. s/1e1/1e2 on the
> 9 LSBs on the instruction decode.
> 
> Reported-by: David Holsgrove <david.holsgrove@xilinx.com>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
>  target-microblaze/translate.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 7d864b1..6f27c24 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -840,7 +840,7 @@ static void dec_bit(DisasContext *dc)
>              LOG_DIS("swapb r%d r%d\n", dc->rd, dc->ra);
>              tcg_gen_bswap32_i32(cpu_R[dc->rd], cpu_R[dc->ra]);
>              break;
> -        case 0x1e1:
> +        case 0x1e2:

Ouch.. I've applied the fix, thanks.

David, was this the bug that was causing the recent errors with the rebased
GCC port?

Cheers,
Edgar