From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:45593)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marex@denx.de>) id 1TWyH4-0001r0-Ux
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 18:46:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <marex@denx.de>) id 1TWyH3-0005Yr-BI
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 18:46:10 -0500
Received: from mail-out.m-online.net ([212.18.0.9]:43881)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <marex@denx.de>) id 1TWyH3-0005VB-55
	for qemu-devel@nongnu.org; Fri, 09 Nov 2012 18:46:09 -0500
From: Marek Vasut <marex@denx.de>
Date: Sat, 10 Nov 2012 00:45:39 +0100
References: <alpine.LFD.2.02.1211012105080.690@bbs.intern>
	<CAFEAcA-H26vzPDapoK_52maoEoHiLZg-qw0ApzP-5t4VSmGWow@mail.gmail.com>
	<509D059F.9000809@redhat.com>
In-Reply-To: <509D059F.9000809@redhat.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201211100045.39497.marex@denx.de>
Subject: Re: [Qemu-devel] [PATCH] ui/vnc.c: Fix crash with VNC
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Gerhard Wiesinger <lists@wiesinger.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, Gerd Hoffmann <kraxel@redhat.com>

Dear Gerd Hoffmann,

> On 11/09/12 10:50, Peter Maydell wrote:
> > On 9 November 2012 10:42, Anthony Liguori <aliguori@us.ibm.com> wrote:
> >> While the abstract discussion is fun, it never hurts to be defensive.  I
> >> agree the root cause is vmware-vga but checking in vnc doesn't hurt.
> > 
> > Defensive programming would suggest doing the clipping in the
> > console.c layer. That sounds a reasonable plan to me (especially
> > if we've hit similar problems multiple times in the past).
> 
> Fully agree, I'll cook up a patch as I'm touching that anyway.
> 
> Question is just whenever we'll go silently fixup stuff in console.c or
> use assert()s to enforce callers getting this correct.  I'd tend to use
> assert() as vmware-vga passing bogous stuff there IMHO indicates there
> is a bug in vmware-vga.

Or rather some revisions of the guest X driver. Though it's worth investigating 
it in the right place indeed.

> cheers,
>   Gerd

Best regards,
Marek Vasut