From: "Daniel P. Berrange" <berrange@redhat.com>
To: Lin Ma <lma@suse.com>
Cc: pbonzini@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add
Date: Mon, 12 Nov 2012 11:18:28 +0000 [thread overview]
Message-ID: <20121112111828.GL19606@redhat.com> (raw)
In-Reply-To: <1352718766-5663-1-git-send-email-lma@suse.com>
On Mon, Nov 12, 2012 at 07:12:46PM +0800, Lin Ma wrote:
> QEMU doesn't check if there are mac collisions when adding nics.
> It causes mac address collisions in guest if adding the nics which
> include existing physical address.
> This patch fixes the issue.
I understand the issue, but are there not use cases where it is
reasonable to have multiple NICs with the same MAC address ? To
me this kind of policy enforcement belongs at a higher level in
the mgmt stack.
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2012-11-12 11:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 11:12 [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add Lin Ma
2012-11-12 11:18 ` Daniel P. Berrange [this message]
2012-11-12 11:26 ` Paolo Bonzini
2012-11-12 11:49 ` Lin Ma
2012-11-12 12:28 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121112111828.GL19606@redhat.com \
--to=berrange@redhat.com \
--cc=lma@suse.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).