From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35038) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXs2H-00082w-Uk for qemu-devel@nongnu.org; Mon, 12 Nov 2012 06:18:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXs2E-0008L4-SU for qemu-devel@nongnu.org; Mon, 12 Nov 2012 06:18:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:8159) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXs2E-0008L0-Kn for qemu-devel@nongnu.org; Mon, 12 Nov 2012 06:18:34 -0500 Date: Mon, 12 Nov 2012 11:18:28 +0000 From: "Daniel P. Berrange" Message-ID: <20121112111828.GL19606@redhat.com> References: <1352718766-5663-1-git-send-email-lma@suse.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1352718766-5663-1-git-send-email-lma@suse.com> Subject: Re: [Qemu-devel] [PATCH] add mac address collision checking for device_add & pci_add Reply-To: "Daniel P. Berrange" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Lin Ma Cc: pbonzini@redhat.com, qemu-devel@nongnu.org On Mon, Nov 12, 2012 at 07:12:46PM +0800, Lin Ma wrote: > QEMU doesn't check if there are mac collisions when adding nics. > It causes mac address collisions in guest if adding the nics which > include existing physical address. > This patch fixes the issue. I understand the issue, but are there not use cases where it is reasonable to have multiple NICs with the same MAC address ? To me this kind of policy enforcement belongs at a higher level in the mgmt stack. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|