From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZ03c-00055d-32 for qemu-devel@nongnu.org; Thu, 15 Nov 2012 09:04:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZ03Z-00029v-0w for qemu-devel@nongnu.org; Thu, 15 Nov 2012 09:04:40 -0500 Date: Thu, 15 Nov 2012 15:04:24 +0100 From: Aurelien Jarno Message-ID: <20121115140424.GC21046@ohm.aurel32.net> References: <20121115021501.GA15630@cs.nctu.edu.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Johnson, Eric" Cc: "qemu-trivial@nongnu.org" , "chenwj@cs.nctu.edu.tw" , "qemu-devel@nongnu.org" , =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= , Jia Liu On Thu, Nov 15, 2012 at 02:34:31AM +0000, Johnson, Eric wrote: > Hi Chen, > > Please only remove the POOL48A opcode. > > The others are documented in the microMIPS64 Instruction Set manual ( http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00087-2B-MIPS64BIS-AFP-03.51.pdf ). See http://www.mips.com/products/architectures/mips64/ for other relavent docs. > > Instead of removing them please surround the POOL32S, DADDIU32, SD32, and LD32 opcodes with > #if defined(TARGET_MIPS64) > I don't think a #if is necessary there, this makes the code more difficult to read, while it doesn't change anything on the generated code. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net