From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:54845)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TZKvP-0007Q8-8H
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 07:21:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TZKvM-00039K-6S
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 07:21:35 -0500
Received: from mail-ee0-f45.google.com ([74.125.83.45]:35398)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TZKvL-000393-WD
	for qemu-devel@nongnu.org; Fri, 16 Nov 2012 07:21:32 -0500
Received: by mail-ee0-f45.google.com with SMTP id d49so1620983eek.4
	for <qemu-devel@nongnu.org>; Fri, 16 Nov 2012 04:21:31 -0800 (PST)
Date: Fri, 16 Nov 2012 13:21:28 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20121116122128.GA29634@stefanha-thinkpad.redhat.com>
References: <1352945534-20257-1-git-send-email-david@gibson.dropbear.id.au>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1352945534-20257-1-git-send-email-david@gibson.dropbear.id.au>
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Remove duplicate property
 definition
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: kwolf@redhat.com, Anthony Liguori <aliguori@us.ibm.com>, Paul 'Rusty' Russell <rusty@rustcorp.com.au>, qemu-devel@nongnu.org

On Thu, Nov 15, 2012 at 01:12:14PM +1100, David Gibson wrote:
> For the virtio-blk device (via virtio-pci) the property "config-wce" is
> defined in two places.  First, it's defined from the
> DEFINE_VIRTIO_BLK_FEATURES macro, second it's defined directly in
> virtio-pci, just two lines above the call to that macro.
> 
> The direct definition in virtio-pci.c is broken, since it operates on the
> 'config_wce' field of VirtIOBlkConf, which is never used anywhere else.
> Therefore, this patch removes both the extra property definition and the
> redundant field it works on.
> 
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Paul 'Rusty' Russell <rusty@rustcorp.com.au>
> 
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
>  hw/virtio-blk.h |    1 -
>  hw/virtio-pci.c |    1 -
>  2 files changed, 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>