From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:45536) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZL62-0001aR-Ck for qemu-devel@nongnu.org; Fri, 16 Nov 2012 07:32:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZL5z-00060O-9k for qemu-devel@nongnu.org; Fri, 16 Nov 2012 07:32:34 -0500 Received: from mail-ee0-f45.google.com ([74.125.83.45]:42525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZL5z-00060F-2Y for qemu-devel@nongnu.org; Fri, 16 Nov 2012 07:32:31 -0500 Received: by mail-ee0-f45.google.com with SMTP id d49so1627299eek.4 for ; Fri, 16 Nov 2012 04:32:30 -0800 (PST) Date: Fri, 16 Nov 2012 13:32:27 +0100 From: Stefan Hajnoczi Message-ID: <20121116123227.GB29634@stefanha-thinkpad.redhat.com> References: <1352984257-29712-1-git-send-email-kwolf@redhat.com> <1352984257-29712-3-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1352984257-29712-3-git-send-email-kwolf@redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 2/2] block: Avoid second open for format probing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: qemu-devel@nongnu.org On Thu, Nov 15, 2012 at 01:57:37PM +0100, Kevin Wolf wrote: > This fixes problems that are caused by the additional open/close cycle > of the existing format probing, for example related to qemu-nbd without > -t option or file descriptor passing. > > Signed-off-by: Kevin Wolf > --- > block.c | 66 ++++++++++++++++++++++++++++++++++++-------------------------- > 1 files changed, 38 insertions(+), 28 deletions(-) Reviewed-by: Stefan Hajnoczi