* [Qemu-devel] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to'.
@ 2012-11-09 11:50 Anthony PERARD
2012-11-12 13:45 ` Markus Armbruster
2012-11-16 13:44 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Anthony PERARD @ 2012-11-09 11:50 UTC (permalink / raw)
To: QEMU-devel
Cc: Anthony PERARD, Paolo Bonzini, qemu-trivial, Markus Armbruster,
Luiz Capitulino
Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken.
This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044.
Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
---
qemu-sockets.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/qemu-sockets.c b/qemu-sockets.c
index abcd791..03ca98d 100644
--- a/qemu-sockets.c
+++ b/qemu-sockets.c
@@ -551,8 +551,9 @@ static InetSocketAddress *inet_parse(const char *str, Error **errp)
optstr = str + pos;
h = strstr(optstr, ",to=");
if (h) {
- if (1 != sscanf(str, "%d%n", &to, &pos) ||
- (str[pos] != '\0' && str[pos] != ',')) {
+ h += 4;
+ if (sscanf(h, "%d%n", &to, &pos) != 1 ||
+ (h[pos] != '\0' && h[pos] != ',')) {
error_setg(errp, "error parsing to= argument");
goto fail;
}
--
Anthony PERARD
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to'.
2012-11-09 11:50 [Qemu-devel] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to' Anthony PERARD
@ 2012-11-12 13:45 ` Markus Armbruster
2012-11-16 13:44 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Markus Armbruster @ 2012-11-12 13:45 UTC (permalink / raw)
To: Anthony PERARD; +Cc: qemu-trivial, Paolo Bonzini, QEMU-devel, Luiz Capitulino
Anthony PERARD <anthony.perard@citrix.com> writes:
> Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken.
> This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks for taking the time to identify the commit that broke it.
Reviewed-by: Markus Armbruster <armbru@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to'.
2012-11-09 11:50 [Qemu-devel] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to' Anthony PERARD
2012-11-12 13:45 ` Markus Armbruster
@ 2012-11-16 13:44 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-11-16 13:44 UTC (permalink / raw)
To: Anthony PERARD
Cc: qemu-trivial, Paolo Bonzini, Luiz Capitulino, QEMU-devel,
Markus Armbruster
On Fri, Nov 09, 2012 at 11:50:54AM +0000, Anthony PERARD wrote:
> Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken.
> This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
>
> ---
> qemu-sockets.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-16 13:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-09 11:50 [Qemu-devel] [PATCH V2] qemu-sockets: Fix parsing of the inet option 'to' Anthony PERARD
2012-11-12 13:45 ` Markus Armbruster
2012-11-16 13:44 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).