From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:47904)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TaNJr-00076o-Dr
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 04:07:10 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TaNJo-0001s3-9P
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 04:07:07 -0500
Received: from mail-bk0-f45.google.com ([209.85.214.45]:42984)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TaNJn-0001rx-PE
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 04:07:03 -0500
Received: by mail-bk0-f45.google.com with SMTP id jk13so796989bkc.4
	for <qemu-devel@nongnu.org>; Mon, 19 Nov 2012 01:07:02 -0800 (PST)
Date: Mon, 19 Nov 2012 10:07:00 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20121119090700.GA18034@stefanha-thinkpad.redhat.com>
References: <1353078798-6472-1-git-send-email-thardeck@suse.de>
	<CAJSP0QW1b_Owt=7VwyGVeN2Rby89SG075Kn+v22UMB_nhXV-Uw@mail.gmail.com>
	<1353281384.3623.38.camel@Thinktank.site>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1353281384.3623.38.camel@Thinktank.site>
Subject: Re: [Qemu-devel] [PATCH] vnc: added initial websockets support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Tim Hardeck <thardeck@suse.de>
Cc: github@martintribe.org, qemu-devel <qemu-devel@nongnu.org>

On Mon, Nov 19, 2012 at 12:29:44AM +0100, Tim Hardeck wrote:
> Hi Stefan,
> 
> thanks for your input but how should it be implemented?
> 
> I personally would like activating Websockets as a VNC option like: "
> -vnc :0 -vnc :1,websockets"
> I have already tested this locally and it does work but only for one
> protocol since QEMU does only interpret the last vnc option.
> So is allowing more than one VNC command line entry in combination with
> having more than one VNC thread for the same display worth working on or
> do you have something different in mind?

I'm not familiar enough with the VNC code to suggest how to best
implement this.

One thing to think about is that Websockets is a transport.  Perhaps the
VNC code itself shouldn't speak it, instead generic QEMU socket code
should implement Websockets so that non-VNC components can also make use
of it in the future.

Stefan