From: Stefan Hajnoczi <stefanha@gmail.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: kwolf@redhat.com, Anthony Liguori <aliguori@us.ibm.com>,
Paul 'Rusty' Russell <rusty@rustcorp.com.au>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Remove duplicate property definition
Date: Mon, 19 Nov 2012 12:38:48 +0100 [thread overview]
Message-ID: <20121119113848.GA22047@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1352945534-20257-1-git-send-email-david@gibson.dropbear.id.au>
On Thu, Nov 15, 2012 at 01:12:14PM +1100, David Gibson wrote:
> For the virtio-blk device (via virtio-pci) the property "config-wce" is
> defined in two places. First, it's defined from the
> DEFINE_VIRTIO_BLK_FEATURES macro, second it's defined directly in
> virtio-pci, just two lines above the call to that macro.
>
> The direct definition in virtio-pci.c is broken, since it operates on the
> 'config_wce' field of VirtIOBlkConf, which is never used anywhere else.
> Therefore, this patch removes both the extra property definition and the
> redundant field it works on.
>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Cc: Anthony Liguori <aliguori@us.ibm.com>
> Cc: Paul 'Rusty' Russell <rusty@rustcorp.com.au>
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/virtio-blk.h | 1 -
> hw/virtio-pci.c | 1 -
> 2 files changed, 2 deletions(-)
Thanks, applied to the block-next tree:
https://github.com/stefanha/qemu/commits/block-next
Stefan
prev parent reply other threads:[~2012-11-19 11:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-15 2:12 [Qemu-devel] [PATCH] virtio-blk: Remove duplicate property definition David Gibson
2012-11-16 12:21 ` Stefan Hajnoczi
2012-11-19 11:38 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119113848.GA22047@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=aliguori@us.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).