* [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field
@ 2012-11-02 15:54 Charles Arnold
2012-11-19 11:42 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Charles Arnold @ 2012-11-02 15:54 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf
block/vpc: Initialize the uuid field in the footer with a generated uuid.
Signed-off-by: Charles Arnold <carnold@suse.com>
diff --git a/block/vpc.c b/block/vpc.c
index b6bf52f..f14c6ae 100644
--- a/block/vpc.c
+++ b/block/vpc.c
@@ -26,6 +26,9 @@
#include "block_int.h"
#include "module.h"
#include "migration.h"
+#if defined(CONFIG_UUID)
+#include <uuid/uuid.h>
+#endif
/**************************************************************/
@@ -739,7 +742,9 @@ static int vpc_create(const char *filename, QEMUOptionParameter *options)
footer->type = be32_to_cpu(disk_type);
- /* TODO uuid is missing */
+#if defined(CONFIG_UUID)
+ uuid_generate(footer->uuid);
+#endif
footer->checksum = be32_to_cpu(vpc_checksum(buf, HEADER_SIZE));
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field
@ 2012-11-12 19:17 Charles Arnold
2012-11-13 10:45 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Charles Arnold @ 2012-11-12 19:17 UTC (permalink / raw)
To: qemu-devel; +Cc: Kevin Wolf, stefanha
Ping?
Is this ok?
- Charles
>>> On 11/2/2012 at 09:54 AM, in message <50A0E829.5B74.0091.0@suse.com>, Charles
Arnold wrote:
> block/vpc: Initialize the uuid field in the footer with a generated uuid.
>
> Signed-off-by: Charles Arnold <carnold@suse.com>
>
> diff --git a/block/vpc.c b/block/vpc.c
> index b6bf52f..f14c6ae 100644
> --- a/block/vpc.c
> +++ b/block/vpc.c
> @@ -26,6 +26,9 @@
> #include "block_int.h"
> #include "module.h"
> #include "migration.h"
> +#if defined(CONFIG_UUID)
> +#include <uuid/uuid.h>
> +#endif
>
> /**************************************************************/
>
> @@ -739,7 +742,9 @@ static int vpc_create(const char *filename,
> QEMUOptionParameter *options)
>
> footer->type = be32_to_cpu(disk_type);
>
> - /* TODO uuid is missing */
> +#if defined(CONFIG_UUID)
> + uuid_generate(footer->uuid);
> +#endif
>
> footer->checksum = be32_to_cpu(vpc_checksum(buf, HEADER_SIZE));
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field
2012-11-12 19:17 Charles Arnold
@ 2012-11-13 10:45 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2012-11-13 10:45 UTC (permalink / raw)
To: Charles Arnold; +Cc: Kevin Wolf, qemu-devel, stefanha
Il 12/11/2012 20:17, Charles Arnold ha scritto:
> Ping?
>
> Is this ok?
>
> - Charles
>
>>>> On 11/2/2012 at 09:54 AM, in message <50A0E829.5B74.0091.0@suse.com>, Charles
> Arnold wrote:
>> block/vpc: Initialize the uuid field in the footer with a generated uuid.
>>
>> Signed-off-by: Charles Arnold <carnold@suse.com>
>>
>> diff --git a/block/vpc.c b/block/vpc.c
>> index b6bf52f..f14c6ae 100644
>> --- a/block/vpc.c
>> +++ b/block/vpc.c
>> @@ -26,6 +26,9 @@
>> #include "block_int.h"
>> #include "module.h"
>> #include "migration.h"
>> +#if defined(CONFIG_UUID)
>> +#include <uuid/uuid.h>
>> +#endif
>>
>> /**************************************************************/
>>
>> @@ -739,7 +742,9 @@ static int vpc_create(const char *filename,
>> QEMUOptionParameter *options)
>>
>> footer->type = be32_to_cpu(disk_type);
>>
>> - /* TODO uuid is missing */
>> +#if defined(CONFIG_UUID)
>> + uuid_generate(footer->uuid);
>> +#endif
>>
>> footer->checksum = be32_to_cpu(vpc_checksum(buf, HEADER_SIZE));
>>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-11-19 11:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-02 15:54 [Qemu-devel] [PATCH] block: vpc initialize the uuid footer field Charles Arnold
2012-11-19 11:42 ` Stefan Hajnoczi
-- strict thread matches above, loose matches on Subject: below --
2012-11-12 19:17 Charles Arnold
2012-11-13 10:45 ` Paolo Bonzini
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).