qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH V5 08/10] Create four opts list related functions
Date: Mon, 19 Nov 2012 18:16:57 +0100	[thread overview]
Message-ID: <20121119171657.GB19114@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1351761150-20705-9-git-send-email-wdongxu@linux.vnet.ibm.com>

On Thu, Nov 01, 2012 at 05:12:28PM +0800, Dong Xu Wang wrote:
> +/* Create a new QemuOptsList and make its desc to the merge of first and second.
> + * It will allocate space for one new QemuOptsList plus enouth space for
> + * QemuOptDesc in first and second QemuOptsList. First argument's QemuOptDesc
> + * members take precedence over second's.
> + */
> +QemuOptsList *append_opts_list(QemuOptsList *first,
> +                               QemuOptsList *second)
> +{
> +    size_t num_first_options, num_second_options;
> +    QemuOptsList *dest = NULL;
> +    int i = 0;
> +    int index = 0;
> +
> +    num_first_options = count_opts_list(first);
> +    num_second_options = count_opts_list(second);
> +    if (num_first_options + num_second_options == 0) {
> +        return NULL;
> +    }
> +
> +    dest = g_malloc0(sizeof(QemuOptsList)
> +        + (num_first_options + num_second_options) * sizeof(QemuOptDesc));

(num_first_options + num_second_options + 1) since we assign
desc[index].name = NULL at the end.

  reply	other threads:[~2012-11-19 17:17 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01  9:12 [Qemu-devel] [PATCH V5 00/10] replace QEMUOptionParameter with QemuOpts parser Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 01/10] qemu-option: opt_set(): split it up into more functions Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 02/10] qemu-option: qemu_opts_validate(): fix duplicated code Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 04/10] introduce qemu_opts_create_nofail function Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 05/10] use qemu_opts_create_nofail Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 06/10] create new function: qemu_opt_set_number Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 07/10] add def_print_str and use it in qemu_opts_print Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 08/10] Create four opts list related functions Dong Xu Wang
2012-11-19 17:16   ` Stefan Hajnoczi [this message]
2012-11-21  2:48     ` Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 09/10] Use QemuOpts support in block layer Dong Xu Wang
2012-11-19 17:14   ` Stefan Hajnoczi
2012-11-21  2:51     ` Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 10/10] remove QEMUOptionParameter related functions and struct Dong Xu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121119171657.GB19114@stefanha-thinkpad.redhat.com \
    --to=stefanha@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=wdongxu@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).