From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:59550)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TaUy5-0007OU-PJ
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 12:17:14 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TaUxw-0006TE-7D
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 12:17:09 -0500
Received: from mail-bk0-f45.google.com ([209.85.214.45]:62684)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <stefanha@gmail.com>) id 1TaUxv-0006SG-WA
	for qemu-devel@nongnu.org; Mon, 19 Nov 2012 12:17:00 -0500
Received: by mail-bk0-f45.google.com with SMTP id jk13so1040647bkc.4
	for <qemu-devel@nongnu.org>; Mon, 19 Nov 2012 09:16:59 -0800 (PST)
Date: Mon, 19 Nov 2012 18:16:57 +0100
From: Stefan Hajnoczi <stefanha@gmail.com>
Message-ID: <20121119171657.GB19114@stefanha-thinkpad.redhat.com>
References: <1351761150-20705-1-git-send-email-wdongxu@linux.vnet.ibm.com>
	<1351761150-20705-9-git-send-email-wdongxu@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1351761150-20705-9-git-send-email-wdongxu@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH V5 08/10] Create four opts list related
 functions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On Thu, Nov 01, 2012 at 05:12:28PM +0800, Dong Xu Wang wrote:
> +/* Create a new QemuOptsList and make its desc to the merge of first and second.
> + * It will allocate space for one new QemuOptsList plus enouth space for
> + * QemuOptDesc in first and second QemuOptsList. First argument's QemuOptDesc
> + * members take precedence over second's.
> + */
> +QemuOptsList *append_opts_list(QemuOptsList *first,
> +                               QemuOptsList *second)
> +{
> +    size_t num_first_options, num_second_options;
> +    QemuOptsList *dest = NULL;
> +    int i = 0;
> +    int index = 0;
> +
> +    num_first_options = count_opts_list(first);
> +    num_second_options = count_opts_list(second);
> +    if (num_first_options + num_second_options == 0) {
> +        return NULL;
> +    }
> +
> +    dest = g_malloc0(sizeof(QemuOptsList)
> +        + (num_first_options + num_second_options) * sizeof(QemuOptDesc));

(num_first_options + num_second_options + 1) since we assign
desc[index].name = NULL at the end.