From: David Gibson <david@gibson.dropbear.id.au>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Michael Ellerman <michael@ellerman.id.au>,
qemu-ppc@nongnu.org, Alexander Graf <agraf@suse.de>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization
Date: Tue, 20 Nov 2012 09:47:03 +1100 [thread overview]
Message-ID: <20121119224703.GB18362@truffula.fritz.box> (raw)
In-Reply-To: <1353354860.23412.93.camel@pasglop>
On Tue, Nov 20, 2012 at 06:54:20AM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2012-11-19 at 17:22 +0100, Alexander Graf wrote:
> > > Currently, the pseries machine initializes the cpus, then the XICS
> > > interrupt controller. However, to support the upcoming in-kernel XICS
> > > implementation we will need to initialize the irq controller before the
> > > vcpus. This patch makes the necesssary rearrangement. This means the
> > > xics init code can no longer auto-detect the number of cpus ("interrupt
> > > servers" in XICS terminology) and so we must pass that in explicitly from
> > > the platform code.
> >
> > Does this still hold true with the new in-kernel interrupt controller workflow?
>
> We need to look into this. The in-kernel ICPs will still certainly be
> created early along with the VCPUs, however we might be able to delay
> the creation of the qemu emulation when not using the former.
I'd really prefer not to have two different initialization orders in
qemu though. I think we'll want the ICP initialization first for CPU
hotplug one day anyway.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
next prev parent reply other threads:[~2012-11-19 22:50 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 2:46 [Qemu-devel] [0/12] Pending pseries patches David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 01/12] pseries: Fix incorrect initialization of interrupt controller David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 02/12] pseries: Use #define for XICS base irq number David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization David Gibson
2012-11-19 16:22 ` Alexander Graf
2012-11-19 19:54 ` Benjamin Herrenschmidt
2012-11-19 22:47 ` David Gibson [this message]
2012-11-20 9:26 ` [Qemu-devel] [Qemu-ppc] " Alexander Graf
2012-11-21 1:10 ` David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 04/12] pseries: Return the token when we register an RTAS call David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 05/12] pseries: Allow RTAS tokens without a qemu handler David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 06/12] pseries: Add tracepoints to the XICS interrupt controller David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 07/12] pseries: Split xics irq configuration from state information David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN David Gibson
2012-11-19 16:26 ` Alexander Graf
2012-11-19 22:48 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-11-20 9:29 ` Alexander Graf
2012-11-20 9:53 ` Peter Maydell
2012-11-20 9:55 ` Alexander Graf
2012-11-21 1:14 ` David Gibson
2012-11-21 1:48 ` Alexander Graf
2012-11-21 1:56 ` David Gibson
2012-11-21 10:07 ` Alexander Graf
2012-11-13 2:46 ` [Qemu-devel] [PATCH 09/12] pseries: Implement PAPR NVRAM David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 10/12] pseries: Update SLOF for NVRAM support David Gibson
2012-11-13 2:46 ` [Qemu-devel] [PATCH 11/12] pseries: Fix bug in PCI MSI allocation David Gibson
2012-11-13 2:47 ` [Qemu-devel] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges David Gibson
2012-11-19 16:34 ` Alexander Graf
2012-11-19 22:51 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-11-20 9:27 ` Alexander Graf
2012-11-20 12:26 ` Michael S. Tsirkin
2012-11-21 0:57 ` David Gibson
2012-11-21 11:34 ` Michael S. Tsirkin
2012-11-21 12:36 ` David Gibson
2012-11-21 13:13 ` Michael S. Tsirkin
2012-11-21 13:21 ` David Gibson
2012-11-21 13:27 ` Alexander Graf
2012-11-21 15:27 ` Michael S. Tsirkin
2012-11-22 2:27 ` David Gibson
2012-11-22 7:23 ` Michael S. Tsirkin
2012-11-22 11:27 ` Alexander Graf
2012-11-22 11:39 ` Michael S. Tsirkin
2012-11-23 4:13 ` David Gibson
2012-11-23 10:53 ` Michael S. Tsirkin
2012-11-23 12:59 ` David Gibson
2012-11-23 13:44 ` Michael S. Tsirkin
2012-11-23 13:44 ` Alexander Graf
2012-11-23 14:01 ` Michael S. Tsirkin
2012-11-23 14:03 ` Alexander Graf
2012-11-23 14:18 ` Michael S. Tsirkin
2012-11-23 14:27 ` Alexander Graf
2012-11-25 23:24 ` David Gibson
2012-11-21 15:20 ` Michael S. Tsirkin
2012-11-21 5:00 ` David Gibson
2012-11-21 10:09 ` Alexander Graf
2012-11-21 11:40 ` Michael S. Tsirkin
2012-11-19 16:35 ` [Qemu-devel] [0/12] Pending pseries patches Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121119224703.GB18362@truffula.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=michael@ellerman.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).