From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56866) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaaAG-0007Zc-Po for qemu-devel@nongnu.org; Mon, 19 Nov 2012 17:50:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaaAF-0001iy-FR for qemu-devel@nongnu.org; Mon, 19 Nov 2012 17:50:04 -0500 Date: Tue, 20 Nov 2012 09:47:03 +1100 From: David Gibson Message-ID: <20121119224703.GB18362@truffula.fritz.box> References: <1352774820-22804-1-git-send-email-david@gibson.dropbear.id.au> <1352774820-22804-4-git-send-email-david@gibson.dropbear.id.au> <1353354860.23412.93.camel@pasglop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1353354860.23412.93.camel@pasglop> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: Michael Ellerman , qemu-ppc@nongnu.org, Alexander Graf , qemu-devel@nongnu.org On Tue, Nov 20, 2012 at 06:54:20AM +1100, Benjamin Herrenschmidt wrote: > On Mon, 2012-11-19 at 17:22 +0100, Alexander Graf wrote: > > > Currently, the pseries machine initializes the cpus, then the XICS > > > interrupt controller. However, to support the upcoming in-kernel XICS > > > implementation we will need to initialize the irq controller before the > > > vcpus. This patch makes the necesssary rearrangement. This means the > > > xics init code can no longer auto-detect the number of cpus ("interrupt > > > servers" in XICS terminology) and so we must pass that in explicitly from > > > the platform code. > > > > Does this still hold true with the new in-kernel interrupt controller workflow? > > We need to look into this. The in-kernel ICPs will still certainly be > created early along with the VCPUs, however we might be able to delay > the creation of the qemu emulation when not using the former. I'd really prefer not to have two different initialization orders in qemu though. I think we'll want the ICP initialization first for CPU hotplug one day anyway. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson