From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56864) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaaAG-0007ZY-Ki for qemu-devel@nongnu.org; Mon, 19 Nov 2012 17:50:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaaAF-0001iu-Fa for qemu-devel@nongnu.org; Mon, 19 Nov 2012 17:50:04 -0500 Date: Tue, 20 Nov 2012 09:48:23 +1100 From: David Gibson Message-ID: <20121119224823.GC18362@truffula.fritz.box> References: <1352774820-22804-1-git-send-email-david@gibson.dropbear.id.au> <1352774820-22804-9-git-send-email-david@gibson.dropbear.id.au> <69634422-E5DA-48E6-807D-5C0333424EB9@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <69634422-E5DA-48E6-807D-5C0333424EB9@suse.de> Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org On Mon, Nov 19, 2012 at 05:26:45PM +0100, Alexander Graf wrote: > > On 13.11.2012, at 03:46, David Gibson wrote: > > > Currently the ppcemb_tlb_t struct, used on a number of embedded ppc models > > to represent a TLB entry contains a hwaddr. That works reasonably for now, > > but is troublesome for saving the state, which we'll want to do in future. > > hwaddr is a large enough type to contain a physical address for any > > supported machine - and can thus, in theory at least, vary depending on > > what machines are enabled other than the one we're actually using right > > now (though in fact it doesn't for ppc). This makes it unsuitable for > > describing in vmstate. > > > > This patch therefore changes ppcemb_tlb_t to use a fixed 64-bit integer > > which we know is sufficient for all the machines which use this structure. > > hwaddr is always defined to 64bit by now. I know, but there aren't state save helpers for hwaddr, and there are objections to creating them. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson