From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:33935)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1TahTg-0005kO-G4
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 01:38:37 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1TahTd-0000Bt-JC
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 01:38:36 -0500
Received: from csmailer.cs.nctu.edu.tw ([140.113.235.130]:29103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <chenwj@cs.nctu.edu.tw>) id 1TahTd-00009V-1j
	for qemu-devel@nongnu.org; Tue, 20 Nov 2012 01:38:33 -0500
Date: Tue, 20 Nov 2012 14:38:23 +0800
From: =?utf-8?B?6Zmz6Z+L5Lu7IChXZWktUmVuIENoZW4p?= <chenwj@iis.sinica.edu.tw>
Message-ID: <20121120063823.GA1775@cs.nctu.edu.tw>
References: <20121116022947.GA50435@cs.nctu.edu.tw>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20121116022947.GA50435@cs.nctu.edu.tw>
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] target-mips: Add comments on POOL32Axf
 encoding
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Aurelien Jarno <aurelien@aurel32.net>
Cc: qemu-devel@nongnu.org, "Johnson, Eric" <ericj@mips.com>, Jia Liu <proljc@gmail.com>

  ping?

On Fri, Nov 16, 2012 at 10:29:47AM +0800, =E9=99=B3=E9=9F=8B=E4=BB=BB (We=
i-Ren Chen) wrote:
> Hi all,
>=20
>   Current QEMU MIPS POOL32AXF encoding comes from microMIPS32
> and microMIPS32 DSP. Add comment here to help reading.
>=20
>   Please review, thanks.
>=20
> Regards,
> chenwj
>=20
> Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw>
> ---
>  target-mips/translate.c |   17 +++++++++++++++++
>  1 files changed, 17 insertions(+), 0 deletions(-)
>=20
> diff --git a/target-mips/translate.c b/target-mips/translate.c
> index 01b48fa..9d4b2c3 100644
> --- a/target-mips/translate.c
> +++ b/target-mips/translate.c
> @@ -10359,6 +10359,19 @@ enum {
> =20
>  /* POOL32AXF encoding of minor opcode field extension */
> =20
> +/*
> + *  1. MIPS Architecture for Programmers Volume II-B:
> + *       The microMIPS32 Instruction Set (Revision 3.05)
> + *
> + *     Table 6.5 POOL32Axf Encoding of Minor Opcode Extension Field =20
> + *
> + *  2. MIPS Architecture for Programmers VolumeIV-e:
> + *       The MIPS DSP Application-Specific Extension
> + *         to the microMIPS32 Architecture (Revision 2.34)
> + *
> + *     Table 5.5 POOL32Axf Encoding of Minor Opcode Extension Field
> + */
> +
>  enum {
>      /* bits 11..6 */
>      TEQ =3D 0x00,
> @@ -10371,6 +10384,8 @@ enum {
>      MFC0 =3D 0x03,
>      MTC0 =3D 0x0b,
> =20
> +    /* begin of microMIPS32 DSP */
> +
>      /* bits 13..12 for 0x01 */
>      MFHI_ACC =3D 0x0,
>      MFLO_ACC =3D 0x1,
> @@ -10387,6 +10402,8 @@ enum {
>      MULT_ACC =3D 0x0,
>      MULTU_ACC =3D 0x1,
> =20
> +    /* end of microMIPS32 DSP */
> +
>      /* bits 15..12 for 0x2c */
>      SEB =3D 0x2,
>      SEH =3D 0x3,
> --=20
> 1.7.3.4

--=20
Wei-Ren Chen (=E9=99=B3=E9=9F=8B=E4=BB=BB)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj