From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43087) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TannL-0005tW-AT for qemu-devel@nongnu.org; Tue, 20 Nov 2012 08:23:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TannF-0005ni-LA for qemu-devel@nongnu.org; Tue, 20 Nov 2012 08:23:19 -0500 Date: Tue, 20 Nov 2012 14:22:58 +0100 From: Stefan Hajnoczi Message-ID: <20121120132258.GF27378@stefanha-thinkpad.redhat.com> References: <1353227175-24596-1-git-send-email-sw@weilnetz.de> <20121119113111.GA21658@stefanha-thinkpad.redhat.com> <50AA6E88.5050303@weilnetz.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50AA6E88.5050303@weilnetz.de> Subject: Re: [Qemu-devel] [Qemu-trivial] [PATCH] block: Fix regression for MinGW (assertion caused by short string) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: qemu-trivial@nongnu.org, Kevin Wolf , Jim Meyering , qemu-devel@nongnu.org On Mon, Nov 19, 2012 at 06:38:16PM +0100, Stefan Weil wrote: > If we want a better solution, we should also consider g_mkstemp > and related functions like g_file_open_tmp. We could also modify > bdrv_create to allow a NULL filename which is interpreted as a > temporary filename. IMHO that would be a good solution for the > future (= after 1.3). Feel free to add a TODO comment to the > code in my patch. For 1.3 please send directly through Anthony or other commiters. I don't want to be a middle-man for last-minute fixes, it will just slow things down. Stefan