From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Stefan Weil <weil@mail.berlios.de>,
qemu-devel@nongnu.org, vbellur@redhat.com
Subject: Re: [Qemu-devel] [PATCH] vdi: don't override libuuid symbols
Date: Tue, 20 Nov 2012 17:15:07 +0100 [thread overview]
Message-ID: <20121120161507.GA7323@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <1353425657-3237-1-git-send-email-stefanha@redhat.com>
On Tue, Nov 20, 2012 at 04:34:17PM +0100, Stefan Hajnoczi wrote:
> It's poor symbol hygiene to provide a global symbols that collide with a
> common library like libuuid. If QEMU links against a shared library
> that depends on uuid_generate() it can end up calling our stub version
> of the function.
>
> This exact scenario happened with GlusterFS libgfapi.so, which depends
> on libglusterfs.so's uuid_generate().
>
> Scope the uuid stubs for vdi.c only and avoid affecting other shared
> objects.
>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> block/vdi.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Thanks, applied to the block tree:
https://github.com/stefanha/qemu/commits/block
Stefan
prev parent reply other threads:[~2012-11-20 16:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 15:34 [Qemu-devel] [PATCH] vdi: don't override libuuid symbols Stefan Hajnoczi
2012-11-20 15:46 ` Kevin Wolf
2012-11-20 16:15 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121120161507.GA7323@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=vbellur@redhat.com \
--cc=weil@mail.berlios.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).