From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaqTn-00005p-QJ for qemu-devel@nongnu.org; Tue, 20 Nov 2012 11:15:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaqTf-0005qG-Ss for qemu-devel@nongnu.org; Tue, 20 Nov 2012 11:15:19 -0500 Received: from mail-bk0-f45.google.com ([209.85.214.45]:50127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaqTf-0005qC-Mn for qemu-devel@nongnu.org; Tue, 20 Nov 2012 11:15:11 -0500 Received: by mail-bk0-f45.google.com with SMTP id jk13so1486801bkc.4 for ; Tue, 20 Nov 2012 08:15:10 -0800 (PST) Date: Tue, 20 Nov 2012 17:15:07 +0100 From: Stefan Hajnoczi Message-ID: <20121120161507.GA7323@stefanha-thinkpad.redhat.com> References: <1353425657-3237-1-git-send-email-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1353425657-3237-1-git-send-email-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH] vdi: don't override libuuid symbols List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Kevin Wolf , Stefan Weil , qemu-devel@nongnu.org, vbellur@redhat.com On Tue, Nov 20, 2012 at 04:34:17PM +0100, Stefan Hajnoczi wrote: > It's poor symbol hygiene to provide a global symbols that collide with a > common library like libuuid. If QEMU links against a shared library > that depends on uuid_generate() it can end up calling our stub version > of the function. > > This exact scenario happened with GlusterFS libgfapi.so, which depends > on libglusterfs.so's uuid_generate(). > > Scope the uuid stubs for vdi.c only and avoid affecting other shared > objects. > > Signed-off-by: Stefan Hajnoczi > --- > block/vdi.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) Thanks, applied to the block tree: https://github.com/stefanha/qemu/commits/block Stefan