From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50953) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaqhY-0001YQ-QX for qemu-devel@nongnu.org; Tue, 20 Nov 2012 11:29:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TaqhS-0003YS-Cj for qemu-devel@nongnu.org; Tue, 20 Nov 2012 11:29:32 -0500 Received: from mail-bk0-f45.google.com ([209.85.214.45]:38108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TaqhS-0003XR-2B for qemu-devel@nongnu.org; Tue, 20 Nov 2012 11:29:26 -0500 Received: by mail-bk0-f45.google.com with SMTP id jk13so1494253bkc.4 for ; Tue, 20 Nov 2012 08:29:25 -0800 (PST) Date: Tue, 20 Nov 2012 17:29:22 +0100 From: Stefan Hajnoczi Message-ID: <20121120162922.GA8665@stefanha-thinkpad.redhat.com> References: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Priebe Cc: pbonzini@redhat.com, ceph-devel@vger.kernel.org, qemu-devel@nongnu.org, pve-devel@pve.proxmox.com, josh.durgin@inktank.com On Tue, Nov 20, 2012 at 01:44:55PM +0100, Stefan Priebe wrote: > rbd / rados tends to return pretty often length of writes > or discarded blocks. These values might be bigger than int. > > Signed-off-by: Stefan Priebe > --- > block/rbd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Looks good but I want to check whether this fixes an bug you've hit? Please indicate details of the bug and how to reproduce it in the commit message. Stefan