From: Stefan Hajnoczi <stefanha@gmail.com>
To: Stefan Priebe - Profihost AG <s.priebe@profihost.ag>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
ceph-devel@vger.kernel.org, qemu-devel <qemu-devel@nongnu.org>,
pve-devel@pve.proxmox.com, josh.durgin@inktank.com
Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int
Date: Wed, 21 Nov 2012 09:43:09 +0100 [thread overview]
Message-ID: <20121121084309.GA17466@stefanha-thinkpad.redhat.com> (raw)
In-Reply-To: <50AC91C4.4070900@profihost.ag>
On Wed, Nov 21, 2012 at 09:33:08AM +0100, Stefan Priebe - Profihost AG wrote:
> Am 21.11.2012 09:26, schrieb Stefan Hajnoczi:
> >On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote:
> >>Am 21.11.2012 07:41, schrieb Stefan Hajnoczi:
> >QEMU is currently in hard freeze and only critical patches should go in.
> >Providing steps to reproduce the bug helps me decide that this patch
> >should still be merged for QEMU 1.3-rc1.
> >
> >Anyway, the patch is straightforward, I have applied it to my block tree
> >and it will be in QEMU 1.3-rc1:
> >https://github.com/stefanha/qemu/commits/block
>
> Thanks!
>
> The steps to reproduce are:
> mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends
> a discard. Important is that you use scsi-hd and set
> discard_granularity=512. Otherwise rbd disabled discard support.
Excellent, thanks! I will add it to the commit description.
> Might you have a look at my other rbd fix too? It fixes a race
> between task cancellation and writes. The same race was fixed in
> iscsi this summer.
Yes.
Stefan
next prev parent reply other threads:[~2012-11-21 8:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 12:44 [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int Stefan Priebe
2012-11-20 16:29 ` Stefan Hajnoczi
2012-11-20 19:16 ` Stefan Priebe
2012-11-21 6:41 ` Stefan Hajnoczi
2012-11-21 7:47 ` Stefan Priebe - Profihost AG
2012-11-21 8:26 ` Stefan Hajnoczi
2012-11-21 8:33 ` Stefan Priebe - Profihost AG
2012-11-21 8:43 ` Stefan Hajnoczi [this message]
2012-11-21 17:03 ` Stefan Weil
2012-11-21 20:53 ` Stefan Priebe - Profihost AG
2012-11-21 22:32 ` Peter Maydell
2012-11-22 8:23 ` Stefan Priebe - Profihost AG
2012-11-22 8:40 ` Peter Maydell
2012-11-22 9:08 ` Stefan Priebe - Profihost AG
-- strict thread matches above, loose matches on Subject: below --
2012-11-21 21:26 Stefan Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121121084309.GA17466@stefanha-thinkpad.redhat.com \
--to=stefanha@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=josh.durgin@inktank.com \
--cc=pbonzini@redhat.com \
--cc=pve-devel@pve.proxmox.com \
--cc=qemu-devel@nongnu.org \
--cc=s.priebe@profihost.ag \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).