From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:37758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb5tq-0005oz-S1 for qemu-devel@nongnu.org; Wed, 21 Nov 2012 03:43:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tb5tp-00030p-Fl for qemu-devel@nongnu.org; Wed, 21 Nov 2012 03:43:14 -0500 Received: from mail-ea0-f173.google.com ([209.85.215.173]:63792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb5tp-0002zk-8x for qemu-devel@nongnu.org; Wed, 21 Nov 2012 03:43:13 -0500 Received: by mail-ea0-f173.google.com with SMTP id i13so2851193eaa.4 for ; Wed, 21 Nov 2012 00:43:12 -0800 (PST) Date: Wed, 21 Nov 2012 09:43:09 +0100 From: Stefan Hajnoczi Message-ID: <20121121084309.GA17466@stefanha-thinkpad.redhat.com> References: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> <20121120162922.GA8665@stefanha-thinkpad.redhat.com> <50ABD713.3050300@profihost.ag> <50AC8704.2020407@profihost.ag> <20121121082616.GB13504@stefanha-thinkpad.redhat.com> <50AC91C4.4070900@profihost.ag> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <50AC91C4.4070900@profihost.ag> Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Priebe - Profihost AG Cc: Paolo Bonzini , ceph-devel@vger.kernel.org, qemu-devel , pve-devel@pve.proxmox.com, josh.durgin@inktank.com On Wed, Nov 21, 2012 at 09:33:08AM +0100, Stefan Priebe - Profihost AG wrote: > Am 21.11.2012 09:26, schrieb Stefan Hajnoczi: > >On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: > >>Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: > >QEMU is currently in hard freeze and only critical patches should go in. > >Providing steps to reproduce the bug helps me decide that this patch > >should still be merged for QEMU 1.3-rc1. > > > >Anyway, the patch is straightforward, I have applied it to my block tree > >and it will be in QEMU 1.3-rc1: > >https://github.com/stefanha/qemu/commits/block > > Thanks! > > The steps to reproduce are: > mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends > a discard. Important is that you use scsi-hd and set > discard_granularity=512. Otherwise rbd disabled discard support. Excellent, thanks! I will add it to the commit description. > Might you have a look at my other rbd fix too? It fixes a race > between task cancellation and writes. The same race was fixed in > iscsi this summer. Yes. Stefan