From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38422)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TbEsG-0003gO-Gk
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 13:18:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TbEsC-0001Gi-6B
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 13:18:12 -0500
Received: from mail-ob0-f173.google.com ([209.85.214.173]:32851)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <flukshun@gmail.com>) id 1TbEsC-0001Ga-15
	for qemu-devel@nongnu.org; Wed, 21 Nov 2012 13:18:08 -0500
Received: by mail-ob0-f173.google.com with SMTP id x4so6899503obh.4
	for <qemu-devel@nongnu.org>; Wed, 21 Nov 2012 10:18:06 -0800 (PST)
Sender: fluxion <flukshun@gmail.com>
Date: Wed, 21 Nov 2012 12:17:50 -0600
From: mdroth <mdroth@linux.vnet.ibm.com>
Message-ID: <20121121181750.GC16281@vm>
References: <1353414712-27072-1-git-send-email-stefanha@redhat.com>
	<1353414712-27072-3-git-send-email-stefanha@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1353414712-27072-3-git-send-email-stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 2/8] configure: add
 CONFIG_VIRTIO_BLK_DATA_PLANE
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Anthony Liguori <aliguori@us.ibm.com>, "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org, khoa@us.ibm.com, Paolo Bonzini <pbonzini@redhat.com>, asias@redhat.com

On Tue, Nov 20, 2012 at 01:31:46PM +0100, Stefan Hajnoczi wrote:
> The virtio-blk-data-plane feature only works with Linux AIO.  Therefore
> add a ./configure option and necessary checks to implement this
> dependency.
> 
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
>  configure | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/configure b/configure
> index 780b19a..633ba6d 100755
> --- a/configure
> +++ b/configure
> @@ -223,6 +223,7 @@ libiscsi=""
>  coroutine=""
>  seccomp=""
>  glusterfs=""
> +virtio_blk_data_plane=""
> 
>  # parse CC options first
>  for opt do
> @@ -871,6 +872,10 @@ for opt do
>    ;;
>    --enable-glusterfs) glusterfs="yes"
>    ;;
> +  --disable-virtio-blk-data-plane) virtio_blk_data_plane="no"
> +  ;;
> +  --enable-virtio-blk-data-plane) virtio_blk_data_plane="yes"
> +  ;;
>    *) echo "ERROR: unknown option $opt"; show_help="yes"
>    ;;
>    esac
> @@ -2233,6 +2238,17 @@ EOF
>  fi
> 
>  ##########################################
> +# adjust virtio-blk-data-plane based on linux-aio
> +
> +if test "$virtio_blk_data_plane" = "yes" -a \
> +	"$linux_aio" != "yes" ; then
> +  echo "Error: virtio-blk-data-plane requires Linux AIO, please try --enable-linux-aio"
> +  exit 1
> +elif test -z "$virtio_blk_data_plane" ; then
> +  virtio_blk_data_plane=$linux_aio
> +fi

$linux_aio gets set automatically if the user has libaio installed and
doesn't specify --disable-linux-aio, so this ends up enabling dataplane by
default in a lot of situations. Since it's experimental I think it should only
be enabled if we pass --enable-virtio-blk-data-plane explicitly.