From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbSJL-0008Dc-CH for qemu-devel@nongnu.org; Thu, 22 Nov 2012 03:39:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbSJK-0003Bf-8h for qemu-devel@nongnu.org; Thu, 22 Nov 2012 03:39:03 -0500 Received: from speedy.comstyle.com ([2001:470:1d:8c::2]:3660 helo=mail.comstyle.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbSJK-0003B3-2l for qemu-devel@nongnu.org; Thu, 22 Nov 2012 03:39:02 -0500 Date: Thu, 22 Nov 2012 03:38:48 -0500 From: Brad Smith Message-ID: <20121122083847.GC4013@rox.home.comstyle.com> References: <1353083843-17175-1-git-send-email-peter.maydell@linaro.org> <50A78ACF.8070206@web.de> <50AD6BFC.9090703@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , Andreas F??rber , patches@linaro.org, Anthony Liguori , qemu-devel@nongnu.org On Thu, Nov 22, 2012 at 08:33:17AM +0000, Peter Maydell wrote: > On 22 November 2012 00:04, Andreas F??rber wrote: > > Am 22.11.2012 00:19, schrieb Peter Maydell: > >> On 17 November 2012 13:10, Peter Maydell wrote: > >>> On 17 November 2012 13:02, Andreas F??rber wrote: > >>>> Am 16.11.2012 17:37, schrieb Peter Maydell: > >>>>> +if test "$(uname -s)" = "Darwin"; then > >>>>> + # On MacOS X the standard supported system compiler is 'cc' (usually clang), > >>>>> + # and 'gcc' is a legacy llvm-gcc which is rather elderly and best avoided. > >>>> > >>>> This comment strikes me as wrong in this generality. It should at least > >>>> be qualified with OSX version numbers. > >>> > >>> How about "and if 'gcc' is not the same as 'cc' then it is a legacy llvm-gcc > >>> which is rather elderly and best avoided" ? I'd rather not get into having > >>> to research which versions of OSX shipped with which compiler as 'cc', > >>> when really the point is that 'cc' will always give you whichever compiler > >>> Apple thought was the best default for that version. > >> > >> Andreas: ping? are you happy with this suggested rephrasing? > > > > Not quite... clang is a relatively new thing. On v10.5.8 ppc64 'cc' is a > > symlink to a real (well, Apple-flavoured) 'gcc-4.0'. > > Yes, that's the case where gcc is the same as cc, ie the "if" condition > in the comment is false. (I guess this is saying my rephrasing is at > best not very clear...) > > > What about "... (clang on recent systems) and 'gcc' may be a legacy > > llvm-gcc ..."? > > Sounds ok. > > >> Do you > >> think this is 1.3 material? (now the static-stublib stuff is in it's > >> less critical, but it still seems like the right idea...) > > > > I wouldn't be opposed to taking the default change into 1.3 as long as > > we can still override it to a specific compiler. > > --cc=whatever remains available. > > > But then again there's the question of why not doing it on Linux as well > > now that we seem to compile under clang, we have cc -> gcc-4.7 on > > openSUSE 12.2. Among our supported platforms only Solaris comes to my > > mind where cc might be an incompatible proprietary compiler. > > Do any of the BSDs ship with some odd non-GPL thing as cc ? non-GPL yes, odd no. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.